From: Hangbin Liu <liuhangbin@gmail.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Vincent Bernat <vincent@bernat.ch>
Subject: Re: [PATCHv2 net 1/4] bonding: fix send_peer_notif overflow
Date: Tue, 2 May 2023 20:45:02 +0800 [thread overview]
Message-ID: <ZFEFzvaRmPL5kLE6@Laptop-X1> (raw)
In-Reply-To: <ZEwmxt4vvw/+2zqI@corigine.com>
On Fri, Apr 28, 2023 at 10:04:22PM +0200, Simon Horman wrote:
> On Thu, Apr 27, 2023 at 11:39:06AM +0800, Hangbin Liu wrote:
>
> ...
>
> > diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> > index c2d080fc4fc4..09a501cdea0c 100644
> > --- a/drivers/net/bonding/bond_netlink.c
> > +++ b/drivers/net/bonding/bond_netlink.c
> > @@ -244,6 +244,12 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> > if (data[IFLA_BOND_PEER_NOTIF_DELAY]) {
> > int delay = nla_get_u32(data[IFLA_BOND_PEER_NOTIF_DELAY]);
> >
> > + if (delay > 300000) {
> > + NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_PEER_NOTIF_DELAY],
> > + "peer_notif_delay should be less than 300s");
> > + return -EINVAL;
> > + }
>
> Hi Hangbin,
>
> can this limit be implemented using NLA_POLICY_MAX() in bond_policy ?
Thanks for the comment, I will update the patch after backing from holiday
next week.
Hangbin
next prev parent reply other threads:[~2023-05-02 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 3:39 [PATCHv2 net 0/4] bonding: fix send_peer_notif overflow Hangbin Liu
2023-04-27 3:39 ` [PATCHv2 net 1/4] " Hangbin Liu
2023-04-28 20:04 ` Simon Horman
2023-05-02 12:45 ` Hangbin Liu [this message]
2023-04-27 3:39 ` [PATCHv2 net 2/4] Documentation: bonding: fix the doc of peer_notif_delay Hangbin Liu
2023-04-27 3:39 ` [PATCHv2 net 3/4] selftests: forwarding: lib: add netns support for tc rule handle stats get Hangbin Liu
2023-04-28 20:08 ` Simon Horman
2023-04-27 3:39 ` [PATCHv2 net 4/4] kselftest: bonding: add num_grat_arp test Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFEFzvaRmPL5kLE6@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=vincent@bernat.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).