From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D4D5D30C; Wed, 3 May 2023 15:34:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B3EBC433D2; Wed, 3 May 2023 15:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683128058; bh=gkPd8aDQYb0daSvr4xmJ+11gUtz98UqLKYxVlN45ATI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iyO9bcnV+KsXcw5bg/cfFOEme1bnL7xc7MqPEXbMOUKtzM88oLWUsrPhUrA4voE0V K8bSrgyvRO5/XAoIIjykJHQx6y5VoOAtx2XrmHWOTuG6wH1RqokcSnkMHKmzWciqvk loE+0gnc0T7JWHrNoaXPWKI8d48lL4KCtBzmHU32qFzPCdxiVTHD/gU9yWoOtlf265 AKOjBxNLLtLlu+e8e5+Xd3LsNqu7sPzI31Ar+fpl8OY5yM6+Uu/CthGjp2ElBXHeAT w5Of+AkRLiDPnKObpfEvA20SVksC7mI25EE9zSqtqQfaM+dUpaxuNiL2dMfuY0DSM2 D/i0/sVVkgnRQ== Date: Wed, 3 May 2023 17:34:12 +0200 From: Simon Horman To: Shenwei Wang Cc: Andrew Lunn , Wei Fang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Clark Wang , dl-linux-imx , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" Subject: Re: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the functions to avoid forward declarations Message-ID: References: <20230502220818.691444-1-shenwei.wang@nxp.com> <20230502220818.691444-2-shenwei.wang@nxp.com> <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 03, 2023 at 12:53:57PM +0000, Shenwei Wang wrote: > > > > -----Original Message----- > > From: Andrew Lunn > > Sent: Tuesday, May 2, 2023 6:19 PM > > To: Shenwei Wang > > Cc: Wei Fang ; David S. Miller ; > > Eric Dumazet ; Jakub Kicinski ; > > Paolo Abeni ; Clark Wang ; dl- > > linux-imx ; Alexei Starovoitov ; Daniel > > Borkmann ; Jesper Dangaard Brouer > > ; John Fastabend ; Alexander > > Lobakin ; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; imx@lists.linux.dev > > Subject: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the functions to > > avoid forward declarations > > > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the message using the 'Report this > > email' button > > > > > > On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote: > > > The patch reorganizes functions related to XDP frame transmission, > > > moving them above the fec_enet_run_xdp implementation. This eliminates > > > the need for forward declarations of these functions. > > > > I'm confused. Are these two patches in the wrong order? > > > > The reason that i asked you to fix the forward declaration in net-next is that it > > makes your fix two patches. Sometimes that is not obvious to people back > > porting patches, and one gets lost, causing build problems. So it is better to have > > a single patch which is maybe not 100% best practice merged to stable, and then > > a cleanup patch merged to the head of development. > > > > If that is the case, we should forgo the second patch. Its purpose was to > reorganize function order such that the subsequent patch to net-next > enabling XDP_TX would not encounter forward declaration issues. I think a good plan would be, as I understood Andrew's original suggestion, to: 1. Only have patch 2/2, targeted at 'net', for now 2. Later, once that patch has been accepted into 'net', 'net-next' has reopened, and that patch is present in 'net-next', then follow-up with patch 1/2, which is a cleanup.