From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FDFB321D; Wed, 3 May 2023 19:07:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0920C433D2; Wed, 3 May 2023 19:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683140847; bh=v+P+/PX3TjpN24HnLhMA+gdDju8JpUR7dNJVSbynO7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=heCwGJg1a8j9gEZnvDK9MSYpw2IWch2gK3oBWWIec3F4mxsyADM9tGsGtnifTVo/H sejlVC6YlRFOOtFAy03iHzwWNfxR+tl3AFuzLH5mQ9VIl0OuoskBLFGMDZXAZgDUXx XiT4hTs3GCI/BXwS0svV6VzYAm1FD586k5B7JSlTr7wiE+TbyXE5/9myA7JzQZm9a2 mzk8quiBZHnDwwZ28RF3EgPwX8n3kl5AkRo+dl+24JMx2Ous0KiKz50KV120B9aTsx ftsxDIZUHnJtu9rWdSf64/qSkX0inUaeebY7DuvwpPn8rKVzdc3hexZELU05l+l3pO BBIXGxkc9Br/A== Date: Wed, 3 May 2023 21:07:18 +0200 From: Simon Horman To: Shenwei Wang Cc: Andrew Lunn , Wei Fang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Clark Wang , dl-linux-imx , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" Subject: Re: [EXT] Re: [PATCH v2 net 2/2] net: fec: restructuring the functions to avoid forward declarations Message-ID: References: <20230502220818.691444-1-shenwei.wang@nxp.com> <20230502220818.691444-2-shenwei.wang@nxp.com> <6dff0a5b-c74b-4516-8461-26fcd5d615f3@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 03, 2023 at 06:41:59PM +0000, Shenwei Wang wrote: ... > > > > On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote: > > > > > The patch reorganizes functions related to XDP frame transmission, > > > > > moving them above the fec_enet_run_xdp implementation. This > > > > > eliminates the need for forward declarations of these functions. > > > > > > > > I'm confused. Are these two patches in the wrong order? > > > > > > > > The reason that i asked you to fix the forward declaration in > > > > net-next is that it makes your fix two patches. Sometimes that is > > > > not obvious to people back porting patches, and one gets lost, > > > > causing build problems. So it is better to have a single patch which > > > > is maybe not 100% best practice merged to stable, and then a cleanup patch > > merged to the head of development. > > > > > > > > > > If that is the case, we should forgo the second patch. Its purpose was > > > to reorganize function order such that the subsequent patch to > > > net-next enabling XDP_TX would not encounter forward declaration issues. > > > > I think a good plan would be, as I understood Andrew's original suggestion, > > to: > > > > 1. Only have patch 2/2, targeted at 'net', for now 2. Later, once that patch has > > been accepted into 'net', 'net-next' has > > reopened, and that patch is present in 'net-next', then follow-up > > with patch 1/2, which is a cleanup. > > So should I re-submit the patch? Or you just take the 1st patch and drop > the 2nd one? net and net-next work on a granularity of patch-sets. So I would suggest re-submitting only patch 2/2 for 'net'. I would also suggest waiting 24h between posting v2 and v3, as per https://kernel.org/doc/html/next/process/maintainer-netdev.html