From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Lorenz Brun <lorenz@brun.one>, netdev@vger.kernel.org
Subject: Re: Quirks for exotic SFP module
Date: Sat, 6 May 2023 11:01:00 +0100 [thread overview]
Message-ID: <ZFYlXFrLl/RdvkFu@shell.armlinux.org.uk> (raw)
In-Reply-To: <d75c2138-76c6-49fe-96c3-39401f18b831@lunn.ch>
On Sat, May 06, 2023 at 02:03:32AM +0200, Andrew Lunn wrote:
> > >
> > > > But the module internally has an AR8033 1000BASE-X to RGMII
> > > > converter which
> > > > is then connected to the modem SoC, so as far as I am aware this is
> > > > incorrect and could cause Linux to do things like autonegotiation
> > > > which
> > > > definitely does not work here.
> > >
> > > Is there anything useful to be gained by talking to the PHY? Since it
> > > appears to be just a media converter, i guess the PHY having link is
> > > not useful. Does the LOS GPIO tell you about the G.Fast modem status?
>
> > AFAIK you cannot talk to the PHY as there isn't really an Ethernet PHY.
>
> So i2c-detect does not find anything other than at address 0x50?
>
> Often the PHY can be access via an MDIO bus over I2C at some other
> address on the bus. The linux SFP code might be trying, even
> succeeding, in instantiating such a bus and finding the PHY. And then
> a PHY driver will be loaded to drive the PHY. This is how Copper SFP
> modules work. However, most Copper SFP use a Marvell PHY, not
> Atheros. And RollBall SFP use a different MDIO over i2c protocol.
Given that the PHY is in 1000base-X to RGMII mode, this is not a usual
setup, and its probably something the PHYLIB driver won't expect. So
we probably don't want to be talking to the PHY, and we probably just
want to talk 1000base-X to the module.
> > I actually haven't checked the LOS GPIO. This thing runs ~1MiB of firmware
> > and two different proprietary management protocols which I've
> > reverse-engineered over which you can get tons of data about the current
> > modem and link status. You need those to boot the SoC anyways. The TX
> > disable GPIO puts the modem SoC into reset state and is used in case you use
> > a host-based watchdog for the module.
>
> So i guess you are not passing the GPIO for TX disable in your DT
> blob. And maybe not LOS. If you do, it must be doing something
> sensible, because phylink does not allow the carrier to go up if LOS
> is active. Although the EEPROM can indicate LOS is not
> implemented. But that assumes the EEPROM contents are sane.
>
> Russell King will be interested in a binary dump from ethtool -m.
Definitely.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-06 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 17:39 Quirks for exotic SFP module Lorenz Brun
2023-05-05 18:53 ` Andrew Lunn
2023-05-05 21:30 ` Lorenz Brun
2023-05-06 0:03 ` Andrew Lunn
2023-05-06 0:26 ` Lorenz Brun
2023-05-06 1:05 ` Andrew Lunn
2023-05-06 1:15 ` Lorenz Brun
2023-05-06 13:35 ` Andrew Lunn
2023-05-06 13:54 ` Russell King (Oracle)
2023-05-06 14:04 ` Lorenz Brun
2023-05-06 10:02 ` Russell King (Oracle)
2023-05-06 10:01 ` Russell King (Oracle) [this message]
2023-05-06 9:57 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFYlXFrLl/RdvkFu@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=lorenz@brun.one \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).