From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31453171AE for ; Mon, 8 May 2023 12:17:37 +0000 (UTC) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C7882E3D6 for ; Mon, 8 May 2023 05:17:34 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-30796c0cbcaso892960f8f.1 for ; Mon, 08 May 2023 05:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1683548253; x=1686140253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oPwugTUEtVq5Uj3H7DR5qqfTvvaV0QUu9h3q5nQeCX4=; b=VVg+QTowSAgRtuHW8vb93EmhtYhqGVCX9BzBM6g61T94jqpBacMgF9b+tB7h+T8/lG TfbShgF9dGpPk7qtZN9muE4EBalexkiiv3fXHkCQb2F8G50DECZlOHJVISvNt1jjOtIL BCFhO48sGe9pP6W3rkDpEqLgV8wut+zPMsINaphirm+ieoTBmKEPJCcTbti+cuorrpUG +pGdg4zeC/Rh9Iyx6/BGFDjlsLlgrzUdkoEUS1FtEWI352/Vdo7ltG8q/992ODusD7un d5N49WjIbEEFo4RRL/zpeY4ef2m0m4oEu4Pgsa1N6Oi7wztMRx8p3NLzQxHXPfXnPYDs UOBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683548253; x=1686140253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oPwugTUEtVq5Uj3H7DR5qqfTvvaV0QUu9h3q5nQeCX4=; b=IBgFACXOnIj9vPtYncKuIrGn+fLE/gmUG/PmvZ6tq0AeJ0KBf/LGIl4BZWpSACgmL0 NRl9k/oncP1Xno90CambbGOYZeJdiW5X7visbx7Q09y0SXJp1bch9ue4Sz0DDH829IDZ bXg0EMVyhUomyNZaMlPo7gLMKquUbUAaN0KJyMqODCjDvnuism56bANxJ2qOPY5W6e3P sc6jCzRQjwRhIoHdUWd1MxD7zKgvX0kAQDYStecm/KaBZgamxHrh/jxmw+R+H39mHxkM B2GwmK9CCV7EJurMSeH0IpmkEmtCCzGs2O2oi12vmCLsJ2dnm1F1CM6f6BuUR9Ll9Q2S 3fxg== X-Gm-Message-State: AC+VfDzjbxVVEwaUGOeYMLQ7xbVn25W+1aHleNEISwuOIhyeDBZYbKzN lqJBXUbD2+hrJD0bKAr98VL9Fw== X-Google-Smtp-Source: ACHHUZ4E6ajP9+kyFa3qZr84KHy9kUfD8AcS49xwioZ0VY0cqr2mu/Czkz/SCfQdsmMB7lKFUi4czw== X-Received: by 2002:a5d:4749:0:b0:2f2:79ce:4836 with SMTP id o9-20020a5d4749000000b002f279ce4836mr7291868wrs.60.1683548252581; Mon, 08 May 2023 05:17:32 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z6-20020adff746000000b002f103ca90cdsm11181011wrp.101.2023.05.08.05.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 05:17:31 -0700 (PDT) Date: Mon, 8 May 2023 14:17:30 +0200 From: Jiri Pirko To: Paolo Abeni Cc: Jakub Kicinski , "Kubalewski, Arkadiusz" , Vadim Fedorenko , Vadim Fedorenko , Jonathan Lemon , poros , mschmidt , "netdev@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-clk@vger.kernel.org" , "Olech, Milena" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230503191643.12a6e559@kernel.org> <20230504090401.597a7a61@kernel.org> <20230504114421.51415018@kernel.org> <20230505083531.57966958@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Mon, May 08, 2023 at 08:50:09AM CEST, pabeni@redhat.com wrote: >On Sun, 2023-05-07 at 09:58 +0200, Jiri Pirko wrote: >> Fri, May 05, 2023 at 05:35:31PM CEST, kuba@kernel.org wrote: >> > On Fri, 5 May 2023 12:41:11 +0200 Jiri Pirko wrote: >> > > >> > Sound perfectly fine, if it's a front panel label, let's call >> > the attribute DPLL_A_PIN_FRONT_PANEL_LABEL. If the pin is not >> > brought out to the front panel it will not have this attr. >> > For other type of labels we should have different attributes. >> >> Hmm, that would kind of embed the pin type into attr which feels wrong. > >Looking at the above from a different angle, the >DPLL_A_PIN_FRONT_PANEL_LABEL attribute will be available only for >DPLL_PIN_TYPE_EXT type pins, which looks legit to me - possibly >renaming DPLL_A_PIN_FRONT_PANEL_LABEL as DPLL_A_PIN_EXT_LABEL. Well sure, in case there is no "label" attr for the rest of the types. Which I believe it is, for the ice implementation in this patchset. Otherwise, there is no way to distinguish between the pins. To have multiple attrs for label for multiple pin types does not make any sense to me, that was my point. > >Cheer, > >Paolo >