From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76722AD43 for ; Mon, 8 May 2023 19:33:33 +0000 (UTC) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2090.outbound.protection.outlook.com [40.107.93.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81105448F for ; Mon, 8 May 2023 12:33:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KwiYB+AySIxpj+EEHjPtCriL2f6GQo0auEfLFENlf5opbYOkXruhqy5cZVi04dQNW1axVGx7UigZQXgF4QvC+pc9T2W5R2lfXk6DG45tqZetoFa+lBFCVXrglzjSuw9+MHRcvrisQt4efRYvAuXKu0plG5jgzqv9oiarWhDhykE61DnHVv541STTG6obRCeuhcTzjnbf8JoZmbIb9yjLBqL41mGph/G+9tbRTqiaiwPTghL6pA8DfyuKvwEk7e4wuj0UiQHNZoybsd7T93d7iva4ejVqRghJIkqzNfLzereIVqDgUTCv12EpTrQhMbZ63RB9d7NFM/HWY18vCZIJCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXG6b7mGseq/vYBZHgaCkVN49X6djXXVyqGlJlblIAs=; b=gYGueAvG4WHZC4nJGMVOgvP1wT/IlUoh6krnSVlrDhe+P40WnO2I6CM1m1tDLWuln1PggSdp1iq9LLcvNzOTripjUYxCmZ+NslYAzDPBuJoe1Qw5XHwEQ2HIZJ1KxU3tHJYsYfpyCH7eUx6uLRAgdQebC0sdDlL9B+k5aLVZS4qIdaYqWOzOWnQDD8InrzkDHFPMxwbRSFXp3BNjFuMGmFxVshdv5vMqDywsqEH5Flgg3eEgOK3J2bodKuhUQqhhzBRatj3GA5+4qHiY8IBbcHAm/EIX5YLpZGHxFCxu2nk8ydloz+ayu8AC1IprilD1+IdAHmvB/igQmzejWCC9Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXG6b7mGseq/vYBZHgaCkVN49X6djXXVyqGlJlblIAs=; b=ATtFZcraXer4Y9VPBLQbrl5k3JLJvIA0HVLqwJBShI7xOm5kZDPel3S2XJ2u4EPDzHuwNCNuF2rIoV7za9BrDWOURQABV6ebV/vjXuuGiLtfSIalOw7TpWZn0JZyxHNMjxvqFHn+pZkE5i8UkWEo4IhHwSIAt+0s2RzLU3mBHTw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4834.namprd13.prod.outlook.com (2603:10b6:a03:36b::10) by SJ0PR13MB5707.namprd13.prod.outlook.com (2603:10b6:a03:407::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 19:33:27 +0000 Received: from BY3PR13MB4834.namprd13.prod.outlook.com ([fe80::d98b:da1b:b1f0:d4d7]) by BY3PR13MB4834.namprd13.prod.outlook.com ([fe80::d98b:da1b:b1f0:d4d7%7]) with mapi id 15.20.6363.032; Mon, 8 May 2023 19:33:27 +0000 Date: Mon, 8 May 2023 21:33:19 +0200 From: Simon Horman To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Nobuhiro Iwamatsu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH net-next v2 02/11] net: stmmac: dwmac-visconti: Make visconti_eth_clock_remove() return void Message-ID: References: <20230508142637.1449363-1-u.kleine-koenig@pengutronix.de> <20230508142637.1449363-3-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230508142637.1449363-3-u.kleine-koenig@pengutronix.de> X-ClientProxiedBy: AM3PR04CA0141.eurprd04.prod.outlook.com (2603:10a6:207::25) To BY3PR13MB4834.namprd13.prod.outlook.com (2603:10b6:a03:36b::10) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4834:EE_|SJ0PR13MB5707:EE_ X-MS-Office365-Filtering-Correlation-Id: 75c48673-5b06-4c7e-a804-08db4ffb18a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ymtXOTXCstB+HA2X9pHIPiLe2sFqnWqNLyf2ScIM6wDjGv2ur87y0Sxseod7hdgYKg7rzHW2K3JbMwpp/ywDURYwAimm4w63XpP+H6/ieQXaQ+tMFTT+C+Cu5M/J3YnqCd/FO72EwmD94LSaEgj6BJsBJSzgJ+ssCPsvRxs5Lul3et6esEx70Jf/5HVE2T0okBXDR3UTdBogNQk5Nq03ZwclVO9PZ6X+009WDZ9g1+eaxtuCafZBi+SRbBTqIY8jpc05/+dW51+PsUSBxmdlFkONssNALVqJK3QaweO92nECzlJHzKacFxp6ln+ljp1+Tbnv/X2l7+zOtWMp3c6fXXLj3doVdrHBAVpZLA+6Z72ttOkZhN0LBOCsLQB/++yK769SQDbKCFZW7HJP06Je4znE2ZzJnlXAZdkgmHa9iQ/EwMOB0UWaFSj9RP3UOees3IyiEpH8qGwSRJRbH9fTNeJIsUZvEuCGt2gnVqL4iLtOTPvtrfr1FZELtsrMufpmb5in2jYTqA2bWvJWRWEmfYyiVdoMXF30sagFA5GIG5BQsEsvcfcnj3qzy1liDD/1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR13MB4834.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(366004)(136003)(39840400004)(346002)(451199021)(66556008)(6916009)(4326008)(66946007)(316002)(478600001)(6486002)(54906003)(66476007)(86362001)(36756003)(6512007)(2616005)(6506007)(6666004)(44832011)(5660300002)(8936002)(41300700001)(7416002)(8676002)(2906002)(4744005)(38100700002)(186003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE1UblJuSHY5NlBRQm44T0RnQXFNNno0NmhiRGs1cmFxQnZ0NFBqNUJNQXRn?= =?utf-8?B?YU01RGRObDBoclZwSWN4VDk0bnNOamxyTFRESjc1aWdZalUrc3BDTksreDBM?= =?utf-8?B?bWR5ajBmcFFWS3BPRGdXMzdCMGhsV3UvYkkxK3BjRmh2Z1dpeXdONGlOR2c0?= =?utf-8?B?cE5Wdkh4ZzRpc1F2VHpwTDlLYWQzSVZERUE2cjRhWW1ZZWw5WDBUMlM0WEJs?= =?utf-8?B?N1RkS1FnREZjMUhQSk5GckJnVVBQSUg3d2o4d3NpYXYzRnY1b3hhVFFuaUdW?= =?utf-8?B?c25kSGs0bmd5UUNLNWI5cHNLR2ZqQStpblpLa0p4WDZGNzh3OXBSZEhZZzhy?= =?utf-8?B?RDEyZm1tSjFRc2xlSkk3d0ZPQThKK1ZzdUVVcFNyV252d29nRWdoamxRcDFY?= =?utf-8?B?YllMZjlGckZqcVhJc29NdHJzbzVES09vTS80U25TRm1EU0xGb3ZDK0t4QWxt?= =?utf-8?B?dWkva2pLb21kNy9yWkhIWTRCYldKR1dqN1dPczlVNTRUQWNUZWtZOG1Uc2pk?= =?utf-8?B?Z2EzL1Z3Ynd3aHpOWXVGOHVKZ3dnTFh3c0x1K0tqdVpqbWtCWklRNGpGb2FT?= =?utf-8?B?cGdwSFQ4cEtwcVJBckwzMWZsVmVMVmJDS2xhOTJRc0RDVWNhT3llWEptaGJk?= =?utf-8?B?Z2NkY1dBNWVOTm12Z2xubXBUNDIyK2kyWVd1Q2FzZ0NxblM4ZzZndmJxd2Iy?= =?utf-8?B?c1kxTWIrMDZrYmZoVnRFTVdxME1kL25GVFZxRzI5Qm1jUndNZVRvNmtxTk13?= =?utf-8?B?UUlEdGZxZ2Z4bE5Bem9xUFExSkR6TEkxK3B4Z3hmVDE1ZXkvbnRWak1Ebm52?= =?utf-8?B?cjB3OFc5cHBuYkxIem93WkxpRDZCZTV5NHFQdndMUXZXR3J4aVJrRUFCYS83?= =?utf-8?B?YTQzakMyUWZsSmx0MlVOdDJPai9GVU9CZllPVlFKdlBsYVNIV3hZVUhKWTBk?= =?utf-8?B?UlFrRW85VXpTUW5vSjM4WHY4b3krOWdpSWJtbnFMRFU3NzF6MHlxMFVtbWdD?= =?utf-8?B?MnIrR3ZCS1BWcmdReUZyNWJneWovTFVaa09NYzhmSy9PSDZnWUJYRzdBOFZ3?= =?utf-8?B?NkQ0VmdqL0lWK0JWYmpSV2IvNTA3d0w5VTQxK2ZQUk05VUFjRFQ4eTNhYzVI?= =?utf-8?B?QS9ZQU5OMmcrNlc1ZUNRak8yd29TbUluMFV4b0NlalRuOFhhdElvME1TWEY1?= =?utf-8?B?K0ZUb28xUW9ZbUovVjdEQllUeG1MUDE2VmNGaUlWSDl1T0llNHhOQ1hnMTdP?= =?utf-8?B?VVkxazJNOHpKSXdnRXREU0JoTjJQRjZVaG10c1ByY0dXTTJOVWpUVEpCZWpj?= =?utf-8?B?cGM2bUFUYU9ROHhqUkhaMWEzN2VnVDFjZEo0YWJnQ1BBR3FacnpCRkhJbEU0?= =?utf-8?B?SE1kRld0cGFrMzR0U3RlaEpFb28vOEk3d0hHc2l3c1RaQkxYY05tclNzL3lu?= =?utf-8?B?OURReWdMV3BNTFdvOTB6aXZpNWNMUHJjcVJWQnVMVVhLWEtoVW5IUVI3TkFC?= =?utf-8?B?Z1dwUVU1a1Q0RnJ5UGs5ajNLUmRZL2cvSDd1eXZGaTBTaWd5cHVrVmEwS0VJ?= =?utf-8?B?SWMwU050Kzl3cENvbjZFejVLMmpFSVRvMmxWSERGWko5L2Fzbkg5dFhLK240?= =?utf-8?B?ODZYWVhJOEw2eHhGU2E0aEVORWJSYWlvdmRlNlhkVVVtL0tEbDhhbDc2WEtH?= =?utf-8?B?YzhNWGlDdktCdDBDQllHVDRFMUIwSGdYNGJaVDBIaWRpcTNqQkptRG1mVEY2?= =?utf-8?B?ejZGUWF0V1h6dS84TmJpQmw5SHZZZkxhVG5OdEdiS0xIMW14cEgySlZXOUdT?= =?utf-8?B?eWhEMDZwMXk0ZlhiRGYzOU1TNlExRndPNnR3R0dWd1MwTG4wZFJrYnNwdUd1?= =?utf-8?B?QXQ2OTQ2OUJoU0VBWWFid0pJYVIzclBlUi91UHk2L1hvQmF1WTRFSTdBTndq?= =?utf-8?B?YXVTN0E0SUQ2RHJuVVFpZTJGTTFRYWQvRE9kV0Rjb1JVWHVsOFUvSnRpQzFS?= =?utf-8?B?eUFsRnBNWkdwNjVoMFpRM294c3lKVnVNRmRpaFBVVDhMQ2s3UzlxMVZvQkxN?= =?utf-8?B?RE56NEZQVXJhaDl4YU1ldDM1YWpwOVBWNWxKb3VxNkE1TWFQRzJMNUF2OHlP?= =?utf-8?B?MWYxSEFwMXgxVEVBaUdyczJYWkdvajRQWFMrbnV3OXd0dnRyTXJ0cTd6OUhw?= =?utf-8?B?RXBRNFlQM05leDRyZldNcVFPc2krRU85QUp5Nkh3eVI5SFFFajIxSlk0MWRJ?= =?utf-8?B?Wmp6OStDV25Qa1pPelhobUxGeTNnPT0=?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75c48673-5b06-4c7e-a804-08db4ffb18a6 X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 19:33:27.3751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NT3NN96ftyt2VDX6Xj/MsCAsZelsA674ITVQ6EBuuVipDVNO5wHvmnWJUhNH6+73kFo9Y7TUyP6lxNJYzO/9UQKwwfjBsMlChuEUxE8VdxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5707 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, May 08, 2023 at 04:26:28PM +0200, Uwe Kleine-König wrote: > The function returns zero unconditionally. Change it to return void > instead which simplifies one caller as error handing becomes > unnecessary. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Simon Horman