[PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

[PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

[Teoh Ji Sheng]

Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
support") introduced ethtool per-queue statistics support to display
number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
This patch extend the support to XGMAC core.

Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index dfd53264e036..070bd912580b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -368,10 +368,12 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,
 
 		if (likely(intr_status & XGMAC_RI)) {
 			x->rx_normal_irq_n++;
+			x->rxq_stats[chan].rx_normal_irq_n++;
 			ret |= handle_rx;
 		}
 		if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
 			x->tx_normal_irq_n++;
+			x->txq_stats[chan].tx_normal_irq_n++;
 			ret |= handle_tx;
 		}
 	}
-- 
2.34.1

RE: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

[Peppe CAVALLARO]

Hello

Idea behind the patch looks ok for me

Regards
peppe


ST Restricted

-----Original Message-----
From: Teoh Ji Sheng <ji.sheng.teoh@intel.com> 
Sent: Monday, May 8, 2023 4:44 PM
To: David S . Miller <davem@davemloft.net>; Peppe CAVALLARO <peppe.cavallaro@st.com>; Alexandre TORGUE - foss <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Teoh Ji Sheng <ji.sheng.teoh@intel.com>
Subject: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
support") introduced ethtool per-queue statistics support to display number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
This patch extend the support to XGMAC core.

Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index dfd53264e036..070bd912580b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -368,10 +368,12 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,
 
 		if (likely(intr_status & XGMAC_RI)) {
 			x->rx_normal_irq_n++;
+			x->rxq_stats[chan].rx_normal_irq_n++;
 			ret |= handle_rx;
 		}
 		if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
 			x->tx_normal_irq_n++;
+			x->txq_stats[chan].tx_normal_irq_n++;
 			ret |= handle_tx;
 		}
 	}
--
2.34.1

Re: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

[Simon Horman]

On Mon, May 08, 2023 at 10:43:40PM +0800, Teoh Ji Sheng wrote:
> Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
> support") introduced ethtool per-queue statistics support to display
> number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
> This patch extend the support to XGMAC core.
> 
> Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH net-next 1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  8 May 2023 22:43:40 +0800 you wrote:
> Commit af9bf70154eb ("net: stmmac: add ethtool per-queue irq statistic
> support") introduced ethtool per-queue statistics support to display
> number of interrupts generated by DMA tx and DMA rx for DWMAC4 core.
> This patch extend the support to XGMAC core.
> 
> Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] net: stmmac: xgmac: add ethtool per-queue irq statistic support
    https://git.kernel.org/netdev/net-next/c/af8eacf2b42e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html