From: Simon Horman <simon.horman@corigine.com>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
Bailey Forrest <bcf@google.com>
Subject: Re: [PATCH net] gve: Remove the code of clearing PBA bit
Date: Wed, 10 May 2023 11:17:34 +0200 [thread overview]
Message-ID: <ZFthLm68Ho6PH6qk@corigine.com> (raw)
In-Reply-To: <20230509225123.11401-1-ziweixiao@google.com>
On Tue, May 09, 2023 at 03:51:23PM -0700, Ziwei Xiao wrote:
> Clearing the PBA bit from the driver is race prone and it may lead to
> dropped interrupt events. This could potentially lead to the traffic
> being completely halted.
>
> Fixes: 5e8c5adf95f8 ("gve: DQO: Add core netdev features")
> Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> Signed-off-by: Bailey Forrest <bcf@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-10 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 22:51 [PATCH net] gve: Remove the code of clearing PBA bit Ziwei Xiao
2023-05-10 9:17 ` Simon Horman [this message]
2023-05-10 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFthLm68Ho6PH6qk@corigine.com \
--to=simon.horman@corigine.com \
--cc=bcf@google.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).