From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3D7E1B8E0 for ; Thu, 11 May 2023 08:00:40 +0000 (UTC) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD74A9EDF for ; Thu, 11 May 2023 01:00:38 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-50c8d87c775so10944189a12.3 for ; Thu, 11 May 2023 01:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1683792037; x=1686384037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wEgpzaMTC/X6SsRH5CQ7hwSBgGWTsbUsbTezZEi8pTI=; b=GfPaQ0CTArFj4Uwryvv+V9goljOzlqoIf+pZCp43gqmDNI4VAs6F0l8Kpl6yGAfaGh CGOqVQzWtTqDaCqvV7Z3gbvSkZBg4YVqpTBV8paMS9QkOrEQV81FfxO85FlpNaRZOM4o Jsu1A+Ip12aFRwyxh1q2NaUCOMTY6ln+Z2RcgBEWB7nWkyMEp39qmFUzJ+xLEIMqNJFf 3t3dcDXA6zphtzQRBS+hN5Hx8JgWNN0ZzilD9GV47UT+mejaSzoG8g+vF9sx8OyhJm+e Q/B5LRXNzI4uGeb31KTMRvzdOvJ1TI/l6jFbjl9F02vrfcWPI5HWGbZwVinVtNuxBHHy 8gZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683792037; x=1686384037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wEgpzaMTC/X6SsRH5CQ7hwSBgGWTsbUsbTezZEi8pTI=; b=kDuaDkl+tJQ/SINxhj5at9d99mVtd0P/PYO8scaWb31Fw364GFOW4tMq3Z6jks6Gyh gRvWzdR2zrIG+gbDPC/oHo5n5CgJaVmopcuKSEYPR+Z0Ra+jFBFvoAwjoAIQUL62UrqR 2o0nBA1zqkUcPQj2pi3B/hSFIZ/m2+cAhHWRPqxYi4Wf8ciSKWSUWZJfjt2qmDfyQlBy n0H05NfxBkmZDYpWqc/QEUd0YAefHKpcuuOsWtNTLuPoBdrkib4+KD+A73ND5DY3YHJA garNqcc2lYfFbYO2JJz4s/nvbBzs5oWJIjYuXQPWerD4jJHNvPNosVvcYWs3JbDhrTDI aofA== X-Gm-Message-State: AC+VfDxFuYlz0PR2xIhECkb+wL8Kx14x1H/tNyrKiqFjPrqg0aWm1yDL wg/2Kz6HrE79Yjw1LXi0IuMH0OfwYEvZa3JPaJA= X-Google-Smtp-Source: ACHHUZ4xkPoobxJSKKK37mixtKZcFyYSdlDYFHBvM5YUr1hTzKRDC8wunLInjvpEQINHv76V1Dsw3g== X-Received: by 2002:a50:fa86:0:b0:508:41df:b276 with SMTP id w6-20020a50fa86000000b0050841dfb276mr16851910edr.22.1683792037046; Thu, 11 May 2023 01:00:37 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id n2-20020aa7c442000000b0050d97582ce1sm2643468edr.48.2023.05.11.01.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 01:00:36 -0700 (PDT) Date: Thu, 11 May 2023 10:00:35 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: Jakub Kicinski , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Vadim Fedorenko Subject: Re: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-2-vadfed@meta.com> <20230504142451.4828bbb5@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Thu, May 11, 2023 at 09:44:30AM CEST, arkadiusz.kubalewski@intel.com wrote: > >>From: Jiri Pirko >>Sent: Friday, May 5, 2023 12:30 PM >> >>Thu, May 04, 2023 at 11:24:51PM CEST, kuba@kernel.org wrote: >>>On Thu, 4 May 2023 14:02:30 +0200 Jiri Pirko wrote: >> >>[...] >> >>> >>>> >+ name: device >>>> >+ subset-of: dpll >>>> >+ attributes: >>>> >+ - >>>> >+ name: id >>>> >+ type: u32 >>>> >+ value: 2 >>>> >+ - >>>> >+ name: dev-name >>>> >+ type: string >>>> >+ - >>>> >+ name: bus-name >>>> >+ type: string >>>> >+ - >>>> >+ name: mode >>>> >+ type: u8 >>>> >+ enum: mode >>>> >+ - >>>> >+ name: mode-supported >>>> >+ type: u8 >>>> >+ enum: mode >>>> >+ multi-attr: true >>>> >+ - >>>> >+ name: lock-status >>>> >+ type: u8 >>>> >+ enum: lock-status >>>> >+ - >>>> >+ name: temp >>>> >+ type: s32 >>>> >+ - >>>> >+ name: clock-id >>>> >+ type: u64 >>>> >+ - >>>> >+ name: type >>>> >+ type: u8 >>>> >+ enum: type >>>> >+ - >>>> >+ name: pin-prio >>>> >+ type: u32 >>>> >+ value: 19 >>>> >>>> Do you still need to pass values for a subset? That is odd. Well, I >>>> think is is odd to pass anything other than names in subset definition, >>>> the rest of the info is in the original attribute set definition, >>>> isn't it? >>>> Jakub? >>> >>>Probably stale code, related bug was fixed in YNL a few months back. >>>Explicit value should no longer be needed. >> >>What about the rest, like type, enum, multi-attr etc. Are they needed >>for subset? If yes, why? >> >> > >It seems the name and type is needed. Without type generation scripts fails. >For now fixed with having only name/type on subset attributes. Okay. Jakub, any idea why "type" is needed here? > >Thanks! >Arkadiusz