From: Jiri Pirko <jiri@resnulli.us>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Dave Ertman <david.m.ertman@intel.com>,
mschmidt@redhat.com, ihuguet@redhat.com,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next 4/5] ice: Remove LAG+SRIOV mutual exclusion
Date: Wed, 24 May 2023 14:08:06 +0200 [thread overview]
Message-ID: <ZG3+Jrok46tEjXLV@nanopsycho> (raw)
In-Reply-To: <20230517165530.3179965-5-anthony.l.nguyen@intel.com>
Wed, May 17, 2023 at 06:55:29PM CEST, anthony.l.nguyen@intel.com wrote:
>From: Dave Ertman <david.m.ertman@intel.com>
>
>There was a change previously to stop SR-IOV and LAG from existing on the
>same interface. This was to prevent the violation of LACP (Link
>Aggregation Control Protocol). The method to achieve this was to add a
>no-op Rx handler onto the netdev when SR-IOV VFs were present, thus
Uff, that is a very ugly misuse of rxhandler :/
Glad to see it go!
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-05-24 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 16:55 [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-05-17 (ice, MAINTAINERS) Tony Nguyen
2023-05-17 16:55 ` [PATCH net-next 1/5] ice: update ICE_PHY_TYPE_HIGH_MAX_INDEX Tony Nguyen
2023-05-17 16:55 ` [PATCH net-next 2/5] ice: refactor PHY type to ethtool link mode Tony Nguyen
2023-05-17 16:55 ` [PATCH net-next 3/5] ice: update PHY type to ethtool link mode mapping Tony Nguyen
2023-05-17 16:55 ` [PATCH net-next 4/5] ice: Remove LAG+SRIOV mutual exclusion Tony Nguyen
2023-05-24 12:08 ` Jiri Pirko [this message]
2023-05-17 16:55 ` [PATCH net-next 5/5] MAINTAINERS: update Intel Ethernet links Tony Nguyen
2023-05-19 3:10 ` [PATCH net-next 0/5][pull request] Intel Wired LAN Driver Updates 2023-05-17 (ice, MAINTAINERS) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG3+Jrok46tEjXLV@nanopsycho \
--to=jiri@resnulli.us \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox