From: Jiri Pirko <jiri@resnulli.us>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
przemyslaw.kitszel@intel.com,
Michal Wilczynski <michal.wilczynski@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next 4/5] ice: Add txbalancing devlink param
Date: Wed, 24 May 2023 13:57:18 +0200 [thread overview]
Message-ID: <ZG37nuqjiZdjQADm@nanopsycho> (raw)
In-Reply-To: <20230523174008.3585300-5-anthony.l.nguyen@intel.com>
Tue, May 23, 2023 at 07:40:07PM CEST, anthony.l.nguyen@intel.com wrote:
>From: Lukasz Czapnik <lukasz.czapnik@intel.com>
>
>It was observed that Tx performance was inconsistent across all queues
>and/or VSIs and that it was directly connected to existing 9-layer
>topology of the Tx scheduler.
>
>Introduce new private devlink param - txbalance. This parameter gives user
>flexibility to choose the 5-layer transmit scheduler topology which helps
>to smooth out the transmit performance.
>
>Allowed parameter values are true for enabled and false for disabled.
>
>Example usage:
>
>Show:
>devlink dev param show pci/0000:4b:00.0 name txbalancing
>pci/0000:4b:00.0:
> name txbalancing type driver-specific
> values:
> cmode permanent value true
"TXbalancing" sounds quite generic. Also, TXbalancing==false might sound
there is no tx balancing. That is confusing.
next prev parent reply other threads:[~2023-05-24 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 17:40 [PATCH net-next 0/5][pull request] ice: Support 5 layer Tx scheduler topology Tony Nguyen
2023-05-23 17:40 ` [PATCH net-next 1/5] ice: Support 5 layer topology Tony Nguyen
2023-05-23 17:40 ` [PATCH net-next 2/5] ice: Adjust the VSI/Aggregator layers Tony Nguyen
2023-05-23 17:40 ` [PATCH net-next 3/5] ice: Enable switching default tx scheduler topology Tony Nguyen
2023-05-23 17:40 ` [PATCH net-next 4/5] ice: Add txbalancing devlink param Tony Nguyen
2023-05-24 11:57 ` Jiri Pirko [this message]
2023-05-25 16:01 ` Lukasz Czapnik
2023-05-23 17:40 ` [PATCH net-next 5/5] ice: Document txbalancing parameter Tony Nguyen
2023-05-24 11:54 ` [PATCH net-next 0/5][pull request] ice: Support 5 layer Tx scheduler topology Jiri Pirko
2023-05-24 13:25 ` Wilczynski, Michal
2023-05-24 16:26 ` Jakub Kicinski
2023-05-24 16:59 ` Wilczynski, Michal
2023-05-24 20:02 ` Jakub Kicinski
2023-05-25 7:49 ` Wilczynski, Michal
2023-05-25 15:41 ` Jakub Kicinski
2023-05-26 7:43 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG37nuqjiZdjQADm@nanopsycho \
--to=jiri@resnulli.us \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=kuba@kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).