From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andrii@kernel.org>, <netdev@vger.kernel.org>,
<magnus.karlsson@intel.com>, <tirthendu.sarkar@intel.com>,
<bjorn@kernel.org>
Subject: Re: [PATCH bpf-next 05/21] xsk: add support for AF_XDP multi-buffer on Rx path
Date: Wed, 24 May 2023 12:28:31 +0200 [thread overview]
Message-ID: <ZG3mz5+5BWtR8+lS@boxer> (raw)
In-Reply-To: <ZGdEn1BLbdcLx/FU@corigine.com>
On Fri, May 19, 2023 at 11:42:55AM +0200, Simon Horman wrote:
> On Thu, May 18, 2023 at 08:05:29PM +0200, Maciej Fijalkowski wrote:
> > From: Tirthendu Sarkar <tirthendu.sarkar@intel.com>
> >
> > Add multi-buffer support for AF_XDP by extending the XDP multi-buffer
> > support to be reflected in user-space when a packet is redirected to
> > an AF_XDP socket.
> >
> > In the XDP implementation, the NIC driver builds the xdp_buff from the
> > first frag of the packet and adds any subsequent frags in the skb_shinfo
> > area of the xdp_buff. In AF_XDP core, XDP buffers are allocated from
> > xdp_sock's pool and data is copied from the driver's xdp_buff and frags.
> >
> > Once an allocated XDP buffer is full and there is still data to be
> > copied, the 'XDP_PKT_CONTD' flag in'options' field of the corresponding
> > xdp ring decriptor is set and passed to the application. When application
>
> nit: checkpatch.pl --codespell says:
>
> :291: WARNING: 'decriptor' may be misspelled - perhaps 'descriptor'?
> xdp ring decriptor is set and passed to the application. When application
> ^^^^^^^^^
Thanks Simon we will run --codespell against the rest of the patches as
well:)
>
> ...
next prev parent reply other threads:[~2023-05-24 10:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 18:05 [PATCH bpf-next 00/21] xsk: multi-buffer support Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 01/21] xsk: prepare 'options' in xdp_desc for multi-buffer use Maciej Fijalkowski
2023-05-18 19:22 ` Stanislav Fomichev
2023-05-19 17:13 ` Alexei Starovoitov
2023-05-24 8:56 ` Sarkar, Tirthendu
2023-05-24 10:27 ` Maciej Fijalkowski
2023-05-24 14:12 ` Alexei Starovoitov
2023-05-24 16:20 ` Stanislav Fomichev
2023-05-24 16:27 ` Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 02/21] xsk: introduce XSK_USE_SG bind flag for xsk socket Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 03/21] xsk: prepare both copy and zero-copy modes to co-exist Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 04/21] xsk: move xdp_buff's data length check to xsk_rcv_check Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 05/21] xsk: add support for AF_XDP multi-buffer on Rx path Maciej Fijalkowski
2023-05-19 9:42 ` Simon Horman
2023-05-24 10:28 ` Maciej Fijalkowski [this message]
2023-05-18 18:05 ` [PATCH bpf-next 06/21] xsk: introduce wrappers and helpers for supporting multi-buffer in Tx path Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 07/21] xsk: allow core/drivers to test EOP bit Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 08/21] xsk: add support for AF_XDP multi-buffer on Tx path Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 09/21] xsk: discard zero length descriptors in " Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 10/21] xsk: support mbuf on ZC RX Maciej Fijalkowski
2023-05-18 21:06 ` kernel test robot
2023-05-18 18:05 ` [PATCH bpf-next 11/21] ice: xsk: add RX multi-buffer support Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 12/21] xsk: support ZC Tx multi-buffer in batch API Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 13/21] xsk: report ZC multi-buffer capability via xdp_features Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 14/21] ice: xsk: Tx multi-buffer support Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 15/21] selftests/xsk: transmit and receive multi-buffer packets Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 16/21] selftests/xsk: add basic multi-buffer test Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 17/21] selftests/xsk: add unaligned mode test for multi-buffer Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 18/21] selftests/xsk: add invalid descriptor " Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 19/21] selftests/xsk: add metadata copy test for multi-buff Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 20/21] selftests/xsk: add test for too many frags Maciej Fijalkowski
2023-05-18 18:05 ` [PATCH bpf-next 21/21] selftests/xsk: reset NIC settings to default after running test suite Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG3mz5+5BWtR8+lS@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).