From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
paul.arola@telus.com, scott.roberts@telus.com,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH net-next v3 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch
Date: Wed, 24 May 2023 14:36:29 +0100 [thread overview]
Message-ID: <ZG4S3QuT6ava3U72@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230524130127.268201-8-alexis.lothore@bootlin.com>
On Wed, May 24, 2023 at 03:01:27PM +0200, Alexis Lothoré wrote:
> diff --git a/drivers/net/dsa/mv88e6xxx/port.h b/drivers/net/dsa/mv88e6xxx/port.h
> index 3c9fc17abdd2..56dfa9d3d4e0 100644
> --- a/drivers/net/dsa/mv88e6xxx/port.h
> +++ b/drivers/net/dsa/mv88e6xxx/port.h
> @@ -138,6 +138,7 @@
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6141 0x3400
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6341 0x3410
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6352 0x3520
> +#define MV88E6XXX_PORT_SWITCH_ID_PROD_6361 0x2610
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6350 0x3710
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6351 0x3750
> #define MV88E6XXX_PORT_SWITCH_ID_PROD_6390 0x3900
This list is ordered by the value in the register. The value you are
adding is 0x2610, which is not ordered between 0x3520 and 0x3710.
Please move this to be after the definition for
MV88E6XXX_PORT_SWITCH_ID_PROD_6250. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-05-24 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 13:01 [PATCH net-next v3 0/7] net: dsa: mv88e6xxx: add 88E6361 support Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 1/7] dt-bindings: net: dsa: marvell: add MV88E6361 switch to compatibility list Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal Alexis Lothoré
2023-05-24 13:18 ` Russell King (Oracle)
2023-05-24 14:46 ` Alexis Lothoré
2023-05-24 17:08 ` Andrew Lunn
2023-05-25 9:08 ` Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 3/7] net: dsa: mv88e6xxx: use mv88e6xxx_phy_is_internal in mv88e6xxx_port_ppu_updates Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 4/7] net: dsa: mv88e6xxx: add field to specify internal phys layout Alexis Lothoré
2023-05-24 17:10 ` Andrew Lunn
2023-05-24 13:01 ` [PATCH net-next v3 5/7] net: dsa: mv88e6xxx: fix 88E6393X family " Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 6/7] net: dsa: mv88e6xxx: pass mv88e6xxx_chip structure to port_max_speed_mode Alexis Lothoré
2023-05-24 13:01 ` [PATCH net-next v3 7/7] net: dsa: mv88e6xxx: enable support for 88E6361 switch Alexis Lothoré
2023-05-24 13:36 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG4S3QuT6ava3U72@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexis.lothore@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=paul.arola@telus.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=scott.roberts@telus.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).