Re: [patch net-next 08/15] sfc: register devlink port with ops

[Jiri Pirko <jiri@resnulli.us>]

Wed, May 24, 2023 at 07:57:50PM CEST, alucerop@amd.com wrote:
>Hi Jiri,
>
>On 5/24/23 13:18, Jiri Pirko wrote:
>> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Awesome, could you manage to remove this irrelevant text in your mailer?


>> 
>> 
>> From: Jiri Pirko <jiri@nvidia.com>
>> 
>> Use newly introduce devlink port registration function variant and
>> register devlink port passing ops.
>> 
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>> ---
>>   drivers/net/ethernet/sfc/efx_devlink.c | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>> index 381b805659d3..f93437757ba3 100644
>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>> @@ -25,6 +25,10 @@ struct efx_devlink {
>>   };
>> 
>>   #ifdef CONFIG_SFC_SRIOV
>> +
>> +static const struct devlink_port_ops sfc_devlink_port_ops = {
>> +};
>> +
>
>We can have devlink port without SRIOV, so we need this outside the previous
>ifdef.

Nope, in the original code, efx_devlink_add_port() is under this ifdef
too. So ifdef-wise, this patch does not change anything. Why do you
think so?


>
>Apart from that, it looks OK. I'll test it and report back.
>
>>   static void efx_devlink_del_port(struct devlink_port *dl_port)
>>   {
>>          if (!dl_port)
>> @@ -57,7 +61,9 @@ static int efx_devlink_add_port(struct efx_nic *efx,
>> 
>>          mport->dl_port.index = mport->mport_id;
>> 
>> -       return devl_port_register(efx->devlink, &mport->dl_port, mport->mport_id);
>> +       return devl_port_register_with_ops(efx->devlink, &mport->dl_port,
>> +                                          mport->mport_id,
>> +                                          &sfc_devlink_port_ops);
>>   }
>> 
>>   static int efx_devlink_port_addr_get(struct devlink_port *port, u8 *hw_addr,
>> --
>> 2.39.2
>> 
>>