From: Simon Horman <simon.horman@corigine.com>
To: wei.fang@nxp.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
netdev@vger.kernel.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()
Date: Thu, 25 May 2023 11:08:52 +0200 [thread overview]
Message-ID: <ZG8lpJvFnZlA3w2q@corigine.com> (raw)
In-Reply-To: <20230525083824.526627-1-wei.fang@nxp.com>
On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
> so remove it.
I think it would be useful to describe why it is useless.
F.e. because it is set to bdp, which doesn't change,
so bdp can be used directly instead.
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
--
pw-bot: cr
next prev parent reply other threads:[~2023-05-25 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 8:38 [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame() wei.fang
2023-05-25 9:08 ` Simon Horman [this message]
2023-05-25 9:46 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG8lpJvFnZlA3w2q@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).