From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, chuck.lever@oracle.com
Subject: Re: [PATCH net-next] net: ynl: prefix uAPI header include with uapi/
Date: Thu, 25 May 2023 11:24:10 +0200 [thread overview]
Message-ID: <ZG8pOlWPDBrxkyD/@corigine.com> (raw)
In-Reply-To: <20230524170901.2036275-1-kuba@kernel.org>
On Wed, May 24, 2023 at 10:09:01AM -0700, Jakub Kicinski wrote:
> To keep things simple we used to include the uAPI header
> in the kernel in the #include <linux/$family.h> format.
> This works well enough, most of the genl families should
> have headers in include/net/ so linux/$family.h ends up
> referring to the uAPI header, anyway. And if it doesn't
> no big deal, we'll just include more info than we need.
>
> Unless that is there is a naming conflict. Someone recently
> created include/linux/psp.h which will be a problem when
> supporting the PSP protocol. (I'm talking about
> work-in-progress patches, but it's just a proof that assuming
> lack of name conflicts was overly optimistic.)
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-25 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 17:09 [PATCH net-next] net: ynl: prefix uAPI header include with uapi/ Jakub Kicinski
2023-05-25 9:24 ` Simon Horman [this message]
2023-05-26 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG8pOlWPDBrxkyD/@corigine.com \
--to=simon.horman@corigine.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).