From: Ido Schimmel <idosch@idosch.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, edumazet@google.com,
jacob.e.keller@intel.com, saeedm@nvidia.com, moshe@nvidia.com
Subject: Re: [patch net] devlink: change per-devlink netdev notifier to static one
Date: Mon, 15 May 2023 16:40:23 +0300 [thread overview]
Message-ID: <ZGI2R2oTm3/+OM5W@shredder> (raw)
In-Reply-To: <ZGInmY/2Rl7xheq6@nanopsycho>
On Mon, May 15, 2023 at 02:37:45PM +0200, Jiri Pirko wrote:
> Mon, May 15, 2023 at 02:05:54PM CEST, idosch@idosch.org wrote:
> >On Mon, May 15, 2023 at 01:35:18PM +0200, Jiri Pirko wrote:
> >> Thanks for the report. From the first sight, don't have a clue what may
> >> be wrong. Debugging.
> >
> >I guess he has CONFIG_NET_NS disabled which turns "__net_initdata" to
> >"__initdata" and frees the notifier block after init. "__net_initdata"
> >is a NOP when CONFIG_NET_NS is enabled.
> >
> >Maybe this will help:
> >
> >diff --git a/net/devlink/core.c b/net/devlink/core.c
> >index 0e58eee44bdb..c23ebabadc52 100644
> >--- a/net/devlink/core.c
> >+++ b/net/devlink/core.c
> >@@ -294,7 +294,7 @@ static struct pernet_operations devlink_pernet_ops __net_initdata = {
> > .pre_exit = devlink_pernet_pre_exit,
> > };
> >
> >-static struct notifier_block devlink_port_netdevice_nb __net_initdata = {
> >+static struct notifier_block devlink_port_netdevice_nb = {
> > .notifier_call = devlink_port_netdevice_event,
> > };
>
> Yeah I just ended up with the same assumption. That is going to fix it.
> Are you sending the proper patch?
Yes. Will send later today
prev parent reply other threads:[~2023-05-15 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230515090912eucas1p2489efdc97f9cf1fddf2aad0449e8a2c7@eucas1p2.samsung.com>
2023-05-10 14:46 ` [patch net] devlink: change per-devlink netdev notifier to static one Jiri Pirko
2023-05-11 1:01 ` Jakub Kicinski
2023-05-11 12:18 ` Simon Horman
2023-05-12 1:10 ` patchwork-bot+netdevbpf
2023-05-15 9:09 ` Marek Szyprowski
2023-05-15 11:35 ` Jiri Pirko
2023-05-15 12:05 ` Ido Schimmel
2023-05-15 12:28 ` Marek Szyprowski
2023-05-15 12:37 ` Jiri Pirko
2023-05-15 13:40 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGI2R2oTm3/+OM5W@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).