From: Piotr Raczynski <piotr.raczynski@intel.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 2/7] net: lan966x: Add support for offloading pcp table
Date: Mon, 15 May 2023 12:24:25 +0200 [thread overview]
Message-ID: <ZGIIWU9MoxSKMWup@nimitz> (raw)
In-Reply-To: <ZGIGkZDW84tHr04f@nimitz>
On Mon, May 15, 2023 at 12:16:49PM +0200, Piotr Raczynski wrote:
[...]
> > +static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_app *app)
> > +{
> > + struct dcb_app app_itr;
> > + int err;
> > + u8 prio;
> > +
> > + err = lan966x_dcb_app_validate(dev, app);
> > + if (err)
> > + goto out;
> > +
> > + /* Delete current mapping, if it exists */
> > + prio = dcb_getapp(dev, app);
> > + if (prio) {
> > + app_itr = *app;
> > + app_itr .priority = prio;
> Compiles OK, still looks little weird :).
>
Other than that, looks OK.
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
[...]
next prev parent reply other threads:[~2023-05-15 10:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 20:10 [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI, DSCP Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 1/7] net: lan966x: Add registers to configure " Horatiu Vultur
2023-05-15 7:43 ` Piotr Raczynski
2023-05-14 20:10 ` [PATCH net-next 2/7] net: lan966x: Add support for offloading pcp table Horatiu Vultur
2023-05-15 10:16 ` Piotr Raczynski
2023-05-15 10:24 ` Piotr Raczynski [this message]
2023-05-16 7:07 ` Paolo Abeni
2023-05-14 20:10 ` [PATCH net-next 3/7] net: lan966x: Add support for apptrust Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 4/7] net: lan966x: Add support for offloading dscp table Horatiu Vultur
2023-05-15 10:22 ` Piotr Raczynski
2023-05-16 7:17 ` Paolo Abeni
2023-05-14 20:10 ` [PATCH net-next 5/7] net: lan966x: Add support for offloading default prio Horatiu Vultur
2023-05-15 15:30 ` Piotr Raczynski
2023-05-14 20:10 ` [PATCH net-next 6/7] net: lan966x: Add support for PCP rewrite Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 7/7] net: lan966x: Add support for DSCP rewrite Horatiu Vultur
2023-05-15 9:55 ` [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI, DSCP Daniel.Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGIIWU9MoxSKMWup@nimitz \
--to=piotr.raczynski@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).