From: Simon Horman <simon.horman@corigine.com>
To: Sundar Nagarajan <sun.nagarajan@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: IPV6_VTI config declaration: tristate line is not indented
Date: Mon, 15 May 2023 14:32:59 +0200 [thread overview]
Message-ID: <ZGIme2Vv3NX3ht7s@corigine.com> (raw)
In-Reply-To: <CALnajPCmN37AU0Dz8NuwZdW3MX2QWiSdyoKSAHGbD0B+dvHoCA@mail.gmail.com>
On Fri, May 12, 2023 at 02:36:08PM -0700, Sundar Nagarajan wrote:
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index 658bfed1d..c4f6bfd20 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -152,7 +152,7 @@ config INET6_TUNNEL
> default n
>
> config IPV6_VTI
> -tristate "Virtual (secure) IPv6: tunneling"
> + tristate "Virtual (secure) IPv6: tunneling"
> select IPV6_TUNNEL
> select NET_IP_TUNNEL
> select XFRM
Unfortunately this patch has been white-space mangled: it looks like
tabs have been converted into spaces. So it doesn't apply.
Using a tool such as git send-email or b4 should help avoid this problem.
A few other things.
* The subject should start with [PATCH net-next], where net-next is the
target tree (as opposed to net, which is for fixes)
Subject: [PATCH net-next v2] ...
* The subject should also include a prefix, in this case probably ipv6
[PATCH net-next v2] ipv6: ...
* Please include a description of the patch, in the body before the patch
itself.
* Please included a signed off by line.
Oveal, Please take a look at the netdev process document.
Link: https://kernel.org/doc/html/latest/process/maintainer-netdev.html
Likewise for your other patch,
- NET_DSA_SJA1105 config declaration: tristate is not indented
Link: https://lore.kernel.org/netdev/CALnajPCaJfR+N=vP0R6bXoUwMbopQK6JsJ+pXxS=T6KT5NXswg@mail.gmail.com/
---
pw-bot: cr
prev parent reply other threads:[~2023-05-15 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 21:36 IPV6_VTI config declaration: tristate line is not indented Sundar Nagarajan
2023-05-15 12:32 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGIme2Vv3NX3ht7s@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sun.nagarajan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).