From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Piotr Raczynski <piotr.raczynski@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <anthony.l.nguyen@intel.com>,
<magnus.karlsson@intel.com>
Subject: Re: [PATCH iwl-net] ice: recycle/free all of the fragments from multi-buffer packet
Date: Mon, 15 May 2023 15:13:05 +0200 [thread overview]
Message-ID: <ZGIv4WAAV088VdSx@boxer> (raw)
In-Reply-To: <ZF5d22ib3IYUMHK9@nimitz>
On Fri, May 12, 2023 at 05:40:11PM +0200, Piotr Raczynski wrote:
> > @@ -1162,6 +1162,9 @@ int ice_clean_rx_irq(struct ice_rx_ring *rx_ring, int budget)
> > bool failure;
> > u32 first;
> >
> > + if (ntc != rx_ring->first_desc)
> > + cached_ntc = rx_ring->first_desc;
> > +
> Would it make sense to apply likely/unlikely here since we check it per
> packet?
This was done before running Rx processing loop so this was not per
packet, only a single check, but in the end we don't need this, see
Simon's reply.
>
> Piotr
> > /* Frame size depend on rx_ring setup when PAGE_SIZE=4K */
> > #if (PAGE_SIZE < 8192)
>
> >
prev parent reply other threads:[~2023-05-15 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 13:23 [PATCH iwl-net] ice: recycle/free all of the fragments from multi-buffer packet Maciej Fijalkowski
2023-05-12 15:37 ` Simon Horman
2023-05-15 13:17 ` Maciej Fijalkowski
2023-05-15 14:39 ` Simon Horman
2023-05-12 15:40 ` Piotr Raczynski
2023-05-15 13:13 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGIv4WAAV088VdSx@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bpf@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.raczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).