From: Ido Schimmel <idosch@idosch.org>
To: Angus Chen <angus.chen@jaguarmicro.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: Remove low_thresh in ip defrag
Date: Tue, 16 May 2023 11:12:42 +0300 [thread overview]
Message-ID: <ZGM6+oaSOXNlf8u2@shredder> (raw)
In-Reply-To: <TY2PR06MB34243E08982541B8371E913085789@TY2PR06MB3424.apcprd06.prod.outlook.com>
On Mon, May 15, 2023 at 12:06:45PM +0000, Angus Chen wrote:
> > -----Original Message-----
> > From: Ido Schimmel <idosch@idosch.org>
> > Sent: Monday, May 15, 2023 7:03 PM
> > To: Angus Chen <angus.chen@jaguarmicro.com>
> > Cc: davem@davemloft.net; dsahern@kernel.org; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2] net: Remove low_thresh in ip defrag
> >
> > On Fri, May 12, 2023 at 09:01:52AM +0800, Angus Chen wrote:
> > > As low_thresh has no work in fragment reassembles,del it.
> > > And Mark it deprecated in sysctl Document.
> > >
> > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> >
> > Getting the following traces with this patch when creating a netns:
> Sorry for test miss because I tested it in card and didn't test it with multi net.
> Should I create a pernet struct for it?
> It may looks too complicated.
Sorry but I don't understand the motivation behind this patch. IIUC, the
sysctl is deprecated and has no use in the kernel, yet it cannot be
removed because user space may rely on it being present. If so, what is
the significance of the code changes in this patch? Why not just update
the documentation?
next prev parent reply other threads:[~2023-05-16 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 1:01 [PATCH v2] net: Remove low_thresh in ip defrag Angus Chen
2023-05-15 7:50 ` patchwork-bot+netdevbpf
2023-05-15 11:02 ` Ido Schimmel
2023-05-15 12:06 ` Angus Chen
2023-05-16 8:12 ` Ido Schimmel [this message]
2023-05-16 8:36 ` Angus Chen
2023-05-15 12:46 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGM6+oaSOXNlf8u2@shredder \
--to=idosch@idosch.org \
--cc=angus.chen@jaguarmicro.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).