From: Simon Horman <simon.horman@corigine.com>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com
Subject: Re: [PATCH net-next v5 1/8] net: wangxun: libwx add tx offload functions
Date: Tue, 16 May 2023 10:13:26 +0200 [thread overview]
Message-ID: <ZGM7JvIckFCGcH9F@corigine.com> (raw)
In-Reply-To: <20230515120829.74861-2-mengyuanlou@net-swift.com>
On Mon, May 15, 2023 at 08:08:22PM +0800, Mengyuan Lou wrote:
> Add tx offload functions for wx_xmit_frame_ring which
> includes wx_encode_tx_desc_ptype, wx_tso and wx_tx_csum.
> which supports ngbe and txgbe to implement tx offload
> function.
>
> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
...
> @@ -326,6 +324,33 @@
>
> #define WX_RXD_ERR_RXE BIT(29) /* Any MAC Error */
>
> +/**
> + * receive packet type
> + * PTYPE:8 = TUN:2 + PKT:2 + TYP:4
> + **/
Hi,
The comment above looks like a kernel-doc but is not.
$ ./scripts/kernel-doc -none drivers/net/ethernet/wangxun/libwx/wx_type.h
drivers/net/ethernet/wangxun/libwx/wx_type.h:328: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
...
next prev parent reply other threads:[~2023-05-16 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 12:08 [PATCH net-next v5 0/8] Wangxun netdev features support Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 1/8] net: wangxun: libwx add tx offload functions Mengyuan Lou
2023-05-16 8:13 ` Simon Horman [this message]
2023-05-15 12:08 ` [PATCH net-next v5 2/8] net: wangxun: libwx add rx " Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 3/8] net: wangxun: Implement vlan add and kill functions Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 4/8] net: libwx: Implement xx_set_features ops Mengyuan Lou
2023-05-16 8:27 ` Simon Horman
2023-05-16 9:26 ` mengyuanlou
2023-05-15 12:08 ` [PATCH net-next v5 5/8] net: ngbe: Add netdev features support Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 6/8] net: ngbe: Implement vlan add and remove ops Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 7/8] net: txgbe: Add netdev features support Mengyuan Lou
2023-05-15 12:08 ` [PATCH net-next v5 8/8] net: txgbe: Implement vlan add and remove ops Mengyuan Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGM7JvIckFCGcH9F@corigine.com \
--to=simon.horman@corigine.com \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).