* [PATCH net-next] net: fec: turn on XDP features
@ 2023-05-18 14:32 wei.fang
2023-05-18 17:47 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: wei.fang @ 2023-05-18 14:32 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend,
shenwei.wang, xiaoning.wang, netdev
Cc: linux-kernel, bpf, linux-imx
From: Wei Fang <wei.fang@nxp.com>
The XDP features are supported since the commit 66c0e13ad236
("drivers: net: turn on XDP features"). Currently, the fec
driver supports NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT
and NETDEV_XDP_ACT_NDO_XMIT. So turn on these XDP features
for fec driver.
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index cd215ab20ff9..577affda6efa 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4030,6 +4030,8 @@ static int fec_enet_init(struct net_device *ndev)
}
ndev->hw_features = ndev->features;
+ ndev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
+ NETDEV_XDP_ACT_NDO_XMIT;
fec_restart(ndev);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: fec: turn on XDP features
2023-05-18 14:32 [PATCH net-next] net: fec: turn on XDP features wei.fang
@ 2023-05-18 17:47 ` Simon Horman
2023-05-18 20:15 ` Lorenzo Bianconi
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2023-05-18 17:47 UTC (permalink / raw)
To: wei.fang
Cc: davem, edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend,
shenwei.wang, xiaoning.wang, netdev, linux-kernel, bpf, linux-imx,
Lorenzo Bianconi
+Lorenzo
On Thu, May 18, 2023 at 10:32:36PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> The XDP features are supported since the commit 66c0e13ad236
> ("drivers: net: turn on XDP features"). Currently, the fec
> driver supports NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT
> and NETDEV_XDP_ACT_NDO_XMIT. So turn on these XDP features
> for fec driver.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index cd215ab20ff9..577affda6efa 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4030,6 +4030,8 @@ static int fec_enet_init(struct net_device *ndev)
> }
>
> ndev->hw_features = ndev->features;
> + ndev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_NDO_XMIT;
>
> fec_restart(ndev);
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: fec: turn on XDP features
2023-05-18 17:47 ` Simon Horman
@ 2023-05-18 20:15 ` Lorenzo Bianconi
2023-05-19 1:27 ` Wei Fang
0 siblings, 1 reply; 4+ messages in thread
From: Lorenzo Bianconi @ 2023-05-18 20:15 UTC (permalink / raw)
To: Simon Horman
Cc: wei.fang, davem, edumazet, kuba, pabeni, ast, daniel, hawk,
john.fastabend, shenwei.wang, xiaoning.wang, netdev, linux-kernel,
bpf, linux-imx, Lorenzo Bianconi
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
> +Lorenzo
>
> On Thu, May 18, 2023 at 10:32:36PM +0800, wei.fang@nxp.com wrote:
> > From: Wei Fang <wei.fang@nxp.com>
> >
> > The XDP features are supported since the commit 66c0e13ad236
> > ("drivers: net: turn on XDP features"). Currently, the fec
> > driver supports NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT
> > and NETDEV_XDP_ACT_NDO_XMIT. So turn on these XDP features
> > for fec driver.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> > drivers/net/ethernet/freescale/fec_main.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> > index cd215ab20ff9..577affda6efa 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -4030,6 +4030,8 @@ static int fec_enet_init(struct net_device *ndev)
> > }
> >
> > ndev->hw_features = ndev->features;
> > + ndev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
> > + NETDEV_XDP_ACT_NDO_XMIT;
should we check FEC_QUIRK_SWAP_FRAME here? something like:
if (!(fep->quirks & FEC_QUIRK_SWAP_FRAME)
ndev->xdp_features = NETDEV_XDP_ACT_BASIC |
NETDEV_XDP_ACT_REDIRECT |
NETDEV_XDP_ACT_NDO_XMIT;
Regards,
Lorenzo
> >
> > fec_restart(ndev);
> >
> > --
> > 2.25.1
> >
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH net-next] net: fec: turn on XDP features
2023-05-18 20:15 ` Lorenzo Bianconi
@ 2023-05-19 1:27 ` Wei Fang
0 siblings, 0 replies; 4+ messages in thread
From: Wei Fang @ 2023-05-19 1:27 UTC (permalink / raw)
To: Lorenzo Bianconi, Simon Horman
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, Shenwei Wang,
Clark Wang, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, dl-linux-imx, Lorenzo Bianconi
> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Sent: 2023年5月19日 4:16
> To: Simon Horman <simon.horman@corigine.com>
> Cc: Wei Fang <wei.fang@nxp.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> ast@kernel.org; daniel@iogearbox.net; hawk@kernel.org;
> john.fastabend@gmail.com; Shenwei Wang <shenwei.wang@nxp.com>; Clark
> Wang <xiaoning.wang@nxp.com>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; bpf@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; Lorenzo Bianconi <lorenzo@kernel.org>
> Subject: Re: [PATCH net-next] net: fec: turn on XDP features
>
> > +Lorenzo
> >
> > On Thu, May 18, 2023 at 10:32:36PM +0800, wei.fang@nxp.com wrote:
> > > From: Wei Fang <wei.fang@nxp.com>
> > >
> > > The XDP features are supported since the commit 66c0e13ad236
> > > ("drivers: net: turn on XDP features"). Currently, the fec driver
> > > supports NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT and
> > > NETDEV_XDP_ACT_NDO_XMIT. So turn on these XDP features for fec
> > > driver.
> > >
> > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > > ---
> > > drivers/net/ethernet/freescale/fec_main.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > > b/drivers/net/ethernet/freescale/fec_main.c
> > > index cd215ab20ff9..577affda6efa 100644
> > > --- a/drivers/net/ethernet/freescale/fec_main.c
> > > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > > @@ -4030,6 +4030,8 @@ static int fec_enet_init(struct net_device *ndev)
> > > }
> > >
> > > ndev->hw_features = ndev->features;
> > > + ndev->xdp_features = NETDEV_XDP_ACT_BASIC |
> NETDEV_XDP_ACT_REDIRECT |
> > > + NETDEV_XDP_ACT_NDO_XMIT;
>
> should we check FEC_QUIRK_SWAP_FRAME here? something like:
>
> if (!(fep->quirks & FEC_QUIRK_SWAP_FRAME)
> ndev->xdp_features = NETDEV_XDP_ACT_BASIC |
> NETDEV_XDP_ACT_REDIRECT |
> NETDEV_XDP_ACT_NDO_XMIT;
>
>
It's really a good suggestion, thank you so much!
> > >
> > > fec_restart(ndev);
> > >
> > > --
> > > 2.25.1
> > >
> > >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-19 1:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-18 14:32 [PATCH net-next] net: fec: turn on XDP features wei.fang
2023-05-18 17:47 ` Simon Horman
2023-05-18 20:15 ` Lorenzo Bianconi
2023-05-19 1:27 ` Wei Fang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).