Re: [PATCH RESEND bpf-next 10/15] ice: Implement VLAN tag hint

Jesper Dangaard Brouer
2023-05-15T15:07:39Z

On 15/05/2023 15.41, Larysa Zaremba wrote:
>>> + *vlan_tag = ice_get_vlan_tag_from_rx_desc(xdp_ext->eop_desc);
>> Should we also do the following:
>>
>> if (!*vlan_tag)
>> return -ENODATA;
>>
>> ?
> Oh, returning VLAN tag with zero value really made sense to me at the beginning,
> but after playing with different kinds of packets, I think returning error makes
> more sense. Will change.
>

IIRC then VLAN tag zero is also a valid id, right?

--Jesper