From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <qiangqing.zhang@nxp.com>,
Andrew Lunn <andrew@lunn.ch>, <kernel@pengutronix.de>
Subject: Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`
Date: Mon, 5 Jun 2023 20:27:38 +0200 [thread overview]
Message-ID: <ZH4pGitjMPiiGgE8@boxer> (raw)
In-Reply-To: <20230605094402.85071-1-csokas.bence@prolan.hu>
On Mon, Jun 05, 2023 at 11:44:03AM +0200, Csókás Bence wrote:
please provide a motivation behind this rename in the commit message.
> Signed-off-by: Csókás Bence <csokas.bence@prolan.hu>
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
> index ab86bb8562ef..afc658d2c271 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -443,21 +443,21 @@ static int fec_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta)
> */
> static int fec_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
> {
> - struct fec_enet_private *adapter =
> + struct fec_enet_private *fep =
> container_of(ptp, struct fec_enet_private, ptp_caps);
> u64 ns;
> unsigned long flags;
>
> - mutex_lock(&adapter->ptp_clk_mutex);
> + mutex_lock(&fep->ptp_clk_mutex);
> /* Check the ptp clock */
> - if (!adapter->ptp_clk_on) {
> - mutex_unlock(&adapter->ptp_clk_mutex);
> + if (!fep->ptp_clk_on) {
> + mutex_unlock(&fep->ptp_clk_mutex);
> return -EINVAL;
> }
> - spin_lock_irqsave(&adapter->tmreg_lock, flags);
> - ns = timecounter_read(&adapter->tc);
> - spin_unlock_irqrestore(&adapter->tmreg_lock, flags);
> - mutex_unlock(&adapter->ptp_clk_mutex);
> + spin_lock_irqsave(&fep->tmreg_lock, flags);
> + ns = timecounter_read(&fep->tc);
> + spin_unlock_irqrestore(&fep->tmreg_lock, flags);
> + mutex_unlock(&fep->ptp_clk_mutex);
>
> *ts = ns_to_timespec64(ns);
>
> --
> 2.25.1
>
>
>
next prev parent reply other threads:[~2023-06-05 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 9:44 [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep` Csókás Bence
2023-06-05 9:51 ` Marc Kleine-Budde
2023-06-05 12:35 ` Csókás Bence
2023-06-05 12:43 ` Marc Kleine-Budde
2023-06-05 12:51 ` Ahmad Fatoum
2023-06-05 18:27 ` Maciej Fijalkowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-04 11:40 Csókás Bence
2023-07-04 19:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH4pGitjMPiiGgE8@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrew@lunn.ch \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).