From: Simon Horman <horms@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Dan Carpenter <dan.carpenter@linaro.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3()
Date: Mon, 5 Jun 2023 20:40:04 +0200 [thread overview]
Message-ID: <ZH4sBF6frp9YjW4T@kernel.org> (raw)
In-Reply-To: <ZH4n7vOXVh9KGExD@boxer>
On Mon, Jun 05, 2023 at 08:22:38PM +0200, Maciej Fijalkowski wrote:
> On Mon, Jun 05, 2023 at 04:20:28PM +0200, Simon Horman wrote:
>
> Hey Simon,
>
> > txgbe_shutdown() relies on txgbe_dev_shutdown() to initialise
> > wake by passing it by reference. However, txgbe_dev_shutdown()
> > doesn't use this parameter at all.
> >
> > wake is then passed uninitialised by txgbe_dev_shutdown()
> > to pci_wake_from_d3().
> >
> > Resolve this problem by:
> > * Removing the unused parameter from txgbe_dev_shutdown()
> > * Removing the uninitialised variable wake from txgbe_dev_shutdown()
> > * Passing false to pci_wake_from_d3() - this assumes that
> > although uninitialised wake was in practice false (0).
> >
> > I'm not sure that this counts as a bug, as I'm not sure that
> > it manifests in any unwanted behaviour. But in any case, the issue
> > was introduced by:
> >
> > bbd22f34b47c ("net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3()")
>
> wait, you are pointing to your own commit here?
>
> this supposed to be:
> 3ce7547e5b71 net: txgbe: Add build support for txgbe
>
> no?
Yes, sorry about that.
Will fix in a v2.
...
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-05 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 14:20 [PATCH net-next] net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3() Simon Horman
2023-06-05 15:10 ` Dan Carpenter
2023-06-05 18:22 ` Maciej Fijalkowski
2023-06-05 18:40 ` Simon Horman [this message]
2023-06-06 8:18 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH4sBF6frp9YjW4T@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).