From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13438125AB for ; Tue, 6 Jun 2023 09:30:45 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6E4E5F; Tue, 6 Jun 2023 02:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bX3B+1lGIzcbVKfEHUtN8MUbXcfS9WOFyXQZwIDBExg=; b=airJ5LgE8sLzCto3YG0rNnzbDT wHfh1Yn2sZQC2ZvFGnCWeyz1D3DYJoMe6cuQZycBlKJ9o2WWpuxbzZfSLGFOIa7ZTYKsSTqGm9w6K axLGxhjDbyxQNsQMRSJcEW/U8ZVO+qfNtfES5A8l5MNm9nCqTSEzG0cn4SVGUEfcHD3H6f2LYRO0s MtPjqphT+cEgtVi/heGupqlRTLgc56a2cjbXo/j9PFRo8748Prpt4xcMRijl3R9utJR/1O0/GCnIb GyV+iv3vN5+PF+decbKdjm8bE6zotFRFRnt3x7OqCGmJZ8SpzuAXvcRoIGhw536861xjQBWYjfe9Y uSLLYlLw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34232) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6T1Q-0005NP-Tg; Tue, 06 Jun 2023 10:30:36 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q6T1M-00070y-6f; Tue, 06 Jun 2023 10:30:32 +0100 Date: Tue, 6 Jun 2023 10:30:32 +0100 From: "Russell King (Oracle)" To: Geert Uytterhoeven Cc: Maxime Chevallier , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman Subject: Re: [PATCH net-next 1/2] net: stmmac: Add PCS_LYNX as a dependency for the whole driver Message-ID: References: <20230606064914.134945-1-maxime.chevallier@bootlin.com> <20230606064914.134945-2-maxime.chevallier@bootlin.com> <889297a0-88c3-90df-7752-efa00184859@linux-m68k.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <889297a0-88c3-90df-7752-efa00184859@linux-m68k.org> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Jun 06, 2023 at 10:29:20AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, 6 Jun 2023, Maxime Chevallier wrote: > > Although pcs_lynx is only used on dwmac_socfpga for now, the cleanup > > path is in the generic driver, and triggers build issues for other > > stmmac variants. Make sure we build pcs_lynx in all cases too, as for > > XPCS. > > That seems suboptimal to me, as it needlesly increases kernel size for > people who do not use dwmac_socfpga. Hence I made an alternative patch: > https://lore.kernel/org/7b36ac43778b41831debd5c30b5b37d268512195.1686039915.git.geert+renesas@glider.be A better solution would be to re-architect the removal code so that whatever creates the PCS is also responsible for removing it. Also, dwmac_socfpga nees to be reorganised anyway, because it calls stmmac_dvr_probe() which then goes on to call register_netdev(), publishing the network device, and then after stmmac_dvr_probe(), further device setup is done. As the basic driver probe flow should be setup and then publish, the existing code structure violates that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!