* [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions
@ 2023-06-04 13:28 Andy Shevchenko
2023-06-06 8:42 ` Simon Horman
2023-06-06 11:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-06-04 13:28 UTC (permalink / raw)
To: Andy Shevchenko, netdev, linux-kernel
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Since hex_to_bin() is provided by hex.h there is no need to require
kernel.h. Replace the latter by the former and add missing export.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/net_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/net_utils.c b/lib/net_utils.c
index c17201df3d08..42bb0473fb22 100644
--- a/lib/net_utils.c
+++ b/lib/net_utils.c
@@ -2,7 +2,8 @@
#include <linux/string.h>
#include <linux/if_ether.h>
#include <linux/ctype.h>
-#include <linux/kernel.h>
+#include <linux/export.h>
+#include <linux/hex.h>
bool mac_pton(const char *s, u8 *mac)
{
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions
2023-06-04 13:28 [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions Andy Shevchenko
@ 2023-06-06 8:42 ` Simon Horman
2023-06-06 11:20 ` Paolo Abeni
2023-06-06 11:30 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-06-06 8:42 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote:
> Since hex_to_bin() is provided by hex.h there is no need to require
> kernel.h. Replace the latter by the former and add missing export.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Andy,
is there a tool that you used to verify this change?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions
2023-06-06 8:42 ` Simon Horman
@ 2023-06-06 11:20 ` Paolo Abeni
2023-06-06 13:04 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2023-06-06 11:20 UTC (permalink / raw)
To: Simon Horman, Andy Shevchenko
Cc: netdev, linux-kernel, David S. Miller, Eric Dumazet,
Jakub Kicinski
On Tue, 2023-06-06 at 10:42 +0200, Simon Horman wrote:
> On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote:
> > Since hex_to_bin() is provided by hex.h there is no need to require
> > kernel.h. Replace the latter by the former and add missing export.h.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Hi Andy,
>
> is there a tool that you used to verify this change?
I guess build testing it should suffice ;)
/P
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions
2023-06-06 11:20 ` Paolo Abeni
@ 2023-06-06 13:04 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-06-06 13:04 UTC (permalink / raw)
To: Paolo Abeni
Cc: Simon Horman, netdev, linux-kernel, David S. Miller, Eric Dumazet,
Jakub Kicinski
On Tue, Jun 06, 2023 at 01:20:57PM +0200, Paolo Abeni wrote:
> On Tue, 2023-06-06 at 10:42 +0200, Simon Horman wrote:
> > On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote:
> > > Since hex_to_bin() is provided by hex.h there is no need to require
> > > kernel.h. Replace the latter by the former and add missing export.h.
...
> > is there a tool that you used to verify this change?
>
> I guess build testing it should suffice ;)
Yes, it was my brain work with reading the code + compile test on x86.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions
2023-06-04 13:28 [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions Andy Shevchenko
2023-06-06 8:42 ` Simon Horman
@ 2023-06-06 11:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-06 11:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: netdev, linux-kernel, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 4 Jun 2023 16:28:58 +0300 you wrote:
> Since hex_to_bin() is provided by hex.h there is no need to require
> kernel.h. Replace the latter by the former and add missing export.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/net_utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next,v1,1/1] mac_pton: Clean up the header inclusions
https://git.kernel.org/netdev/net-next/c/8d2b2281aea9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-06 13:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-04 13:28 [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions Andy Shevchenko
2023-06-06 8:42 ` Simon Horman
2023-06-06 11:20 ` Paolo Abeni
2023-06-06 13:04 ` Andy Shevchenko
2023-06-06 11:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).