[PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Andy Shevchenko]

There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
GPIO sysfs is deprecated. That said, simply drop the stray call.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/ieee802154/ca8210.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index a2d242034220..f9b10e84de06 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi)
 	);
 	if (ret) {
 		dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
-		gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
 		gpio_free(pdata->gpio_irq);
 	}
 
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Miquel Raynal]

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38
+0300:

> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Any reason not to consider a backport into stable kernels?
Cc: stable + Fixes would certainly be welcome in this case?

> ---
>  drivers/net/ieee802154/ca8210.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index a2d242034220..f9b10e84de06 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi)
>  	);
>  	if (ret) {
>  		dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
> -		gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
>  		gpio_free(pdata->gpio_irq);
>  	}
>  


Thanks,
Miquèl

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Simon Horman]

On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Andy Shevchenko]

On Mon, May 29, 2023 at 10:12:13AM +0200, Miquel Raynal wrote:
> andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38
> +0300:
> 
> > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Any reason not to consider a backport into stable kernels?
> Cc: stable + Fixes would certainly be welcome in this case?

I don't think it's justified for stable. It doesn't fix any existing regression
as far as I understand.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Andy Shevchenko]

On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Thank you!
Can this be applied now?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Alexander Aring]

Hi,

On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> Thank you!
> Can this be applied now?

ping, Miquel? :)

- Alex

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Miquel Raynal]

aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:

> Hi,
> 
> On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:  
> > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:  
> > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > >
> > > Reviewed-by: Simon Horman <simon.horman@corigine.com>  
> >
> > Thank you!
> > Can this be applied now?  
> 
> ping, Miquel? :)

I already applied it locally, but I am trying to fix my "thanks for
patch" routine to not tell you it was applied on the mtd tree :-p

Cheers,
Miquèl

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Alexander Aring]

Hi Miquel,

On Tue, Jun 6, 2023 at 5:47 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>
> aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:
>
> > Hi,
> >
> > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> > >
> > > Thank you!
> > > Can this be applied now?
> >
> > ping, Miquel? :)
>
> I already applied it locally, but I am trying to fix my "thanks for
> patch" routine to not tell you it was applied on the mtd tree :-p

okay no problem. Fully understandable as we have a new workflow
mechanism for 802.15.4.

Thanks. :)

- Alex

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Andy Shevchenko]

On Tue, Jun 06, 2023 at 11:47:43AM +0200, Miquel Raynal wrote:
> aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:
> > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:  
> > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:  
> > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > > >
> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com>  
> > >
> > > Thank you!
> > > Can this be applied now?  
> > 
> > ping, Miquel? :)
> 
> I already applied it locally, but I am trying to fix my "thanks for
> patch" routine to not tell you it was applied on the mtd tree :-p

Good to know and thank you!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call

[Miquel Raynal]

On Sun, 2023-05-28 at 14:09:38 UTC, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging, thanks.

Miquel