* [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
@ 2023-05-25 14:57 Neal Cardwell
2023-05-26 9:29 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Neal Cardwell @ 2023-05-25 14:57 UTC (permalink / raw)
To: David Miller, Jakub Kicinski, Eric Dumazet; +Cc: netdev, Neal Cardwell
From: Neal Cardwell <ncardwell@google.com>
Currently TCP_SYNQ_INTERVAL is defined but never used.
According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
the last references to TCP_SYNQ_INTERVAL were removed by 2015
commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
Signed-off-by: Neal Cardwell <ncardwell@google.com>
---
include/net/tcp.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 02a6cff1827e..8123de1e0db9 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -161,8 +161,6 @@ void tcp_time_wait(struct sock *sk, int state, int timeo);
#define MAX_TCP_KEEPCNT 127
#define MAX_TCP_SYNCNT 127
-#define TCP_SYNQ_INTERVAL (HZ/5) /* Period of SYNACK timer */
-
#define TCP_PAWS_24DAYS (60 * 60 * 24 * 24)
#define TCP_PAWS_MSL 60 /* Per-host timestamps are invalidated
* after this time. It should be equal
--
2.40.1.698.g37aff9b760-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
2023-05-25 14:57 [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition Neal Cardwell
@ 2023-05-26 9:29 ` Simon Horman
2023-05-26 9:45 ` Eric Dumazet
2023-05-26 10:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-05-26 9:29 UTC (permalink / raw)
To: Neal Cardwell
Cc: David Miller, Jakub Kicinski, Eric Dumazet, netdev, Neal Cardwell,
Paolo Abeni
+ missing maintainer, Paolo.
On Thu, May 25, 2023 at 10:57:36AM -0400, Neal Cardwell wrote:
> From: Neal Cardwell <ncardwell@google.com>
>
> Currently TCP_SYNQ_INTERVAL is defined but never used.
>
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
2023-05-25 14:57 [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition Neal Cardwell
2023-05-26 9:29 ` Simon Horman
@ 2023-05-26 9:45 ` Eric Dumazet
2023-05-26 10:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2023-05-26 9:45 UTC (permalink / raw)
To: Neal Cardwell; +Cc: David Miller, Jakub Kicinski, netdev, Neal Cardwell
On Thu, May 25, 2023 at 4:57 PM Neal Cardwell <ncardwell.sw@gmail.com> wrote:
>
> From: Neal Cardwell <ncardwell@google.com>
>
> Currently TCP_SYNQ_INTERVAL is defined but never used.
>
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
Someone is cleaning up packetdrill tests ;)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
2023-05-25 14:57 [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition Neal Cardwell
2023-05-26 9:29 ` Simon Horman
2023-05-26 9:45 ` Eric Dumazet
@ 2023-05-26 10:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-26 10:40 UTC (permalink / raw)
To: Neal Cardwell; +Cc: davem, kuba, edumazet, netdev, ncardwell
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 25 May 2023 10:57:36 -0400 you wrote:
> From: Neal Cardwell <ncardwell@google.com>
>
> Currently TCP_SYNQ_INTERVAL is defined but never used.
>
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
>
> [...]
Here is the summary with links:
- [net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
https://git.kernel.org/netdev/net-next/c/f26f03b30319
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-26 10:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 14:57 [PATCH net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition Neal Cardwell
2023-05-26 9:29 ` Simon Horman
2023-05-26 9:45 ` Eric Dumazet
2023-05-26 10:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).