* [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir
@ 2023-05-25 17:27 Osama Muhammad
2023-05-26 7:30 ` Simon Horman
2023-05-26 11:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Osama Muhammad @ 2023-05-25 17:27 UTC (permalink / raw)
To: krzysztof.kozlowski, simon.horman; +Cc: netdev, Osama Muhammad
This patch fixes the error checking in nfcsim.c.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
---
changes since v1:
-Dropped the error checking for debugfs_create_dir
---
drivers/nfc/nfcsim.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c
index 44eeb17ae48d..a55381f80cd6 100644
--- a/drivers/nfc/nfcsim.c
+++ b/drivers/nfc/nfcsim.c
@@ -336,10 +336,6 @@ static struct dentry *nfcsim_debugfs_root;
static void nfcsim_debugfs_init(void)
{
nfcsim_debugfs_root = debugfs_create_dir("nfcsim", NULL);
-
- if (!nfcsim_debugfs_root)
- pr_err("Could not create debugfs entry\n");
-
}
static void nfcsim_debugfs_remove(void)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir
2023-05-25 17:27 [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir Osama Muhammad
@ 2023-05-26 7:30 ` Simon Horman
2023-05-26 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-05-26 7:30 UTC (permalink / raw)
To: Osama Muhammad; +Cc: krzysztof.kozlowski, netdev
On Thu, May 25, 2023 at 10:27:46PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in nfcsim.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
Thanks, LGTM.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir
2023-05-25 17:27 [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir Osama Muhammad
2023-05-26 7:30 ` Simon Horman
@ 2023-05-26 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-26 11:20 UTC (permalink / raw)
To: Osama Muhammad; +Cc: krzysztof.kozlowski, simon.horman, netdev
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 25 May 2023 22:27:46 +0500 you wrote:
> This patch fixes the error checking in nfcsim.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
>
> [...]
Here is the summary with links:
- [v2] nfcsim.c: Fix error checking for debugfs_create_dir
https://git.kernel.org/netdev/net/c/9b9e46aa0727
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-26 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 17:27 [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir Osama Muhammad
2023-05-26 7:30 ` Simon Horman
2023-05-26 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).