From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675801DDD2 for ; Fri, 26 May 2023 14:02:34 +0000 (UTC) Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DFC2F2 for ; Fri, 26 May 2023 07:02:32 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2afb2875491so7692191fa.1 for ; Fri, 26 May 2023 07:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferroamp-se.20221208.gappssmtp.com; s=20221208; t=1685109750; x=1687701750; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I24xOJUPwotirG7z+TXrhtcscl8kClafHqUY8HoH3jQ=; b=U+37g5QCWau8FMMqFyw7/ahikzVlf58I9L65O/nwVQziYDrjPcZMznL3rckunSpQHc kJNnr3PR8YRLcbN+E64/qviorAojRf7lrZ4es3pYuzv4RTaFFIcu0CbuopJ3Iq1R/Yjx BLtTtxR34MZEG3RO9GNxPiwD6yps/wmpiwmoPerA71MfLWpHG1X1XmeUgwvNvHCDgx/5 E8gnoO8y7AtFcQr3fbnK7pCXJUPeKVBbPoZXTQIe54/+l+i4HKzSqHwcTdvD2iOWWg9x mBhebsRjbe5PkzJKUYtsqFy/ZgEcgcUCFdKWzwACYyWxl6JI+MVmiOu9Z2frtVdFtpYM 6T0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685109750; x=1687701750; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I24xOJUPwotirG7z+TXrhtcscl8kClafHqUY8HoH3jQ=; b=jA8pnNkWPWnRUuPiRYBQGuzCQA3x3tUDLBMlWwB91+Ku2aCX6vBgY2X5NmCUkkAsgZ NeUuj1PmEkK1z+EhpRiKt2QA3hNMXPPMV1jjoAicOdNICH4kA8KfBK6+U5Bgznlbs9ii RqBevMww8ZVA0kLEns52Hj1fBzNdHF0eLfPifmgatDc5Jmg6CHpnDXfb3YXNF7sTMSba diPifErviaUpigu892tXMbkAvSYJ7t70GFcArhJuAfYGDYm/Dtmq01kbAeuMdJWzxiow qnyYMYkpoqDKIus4pRvJegw1HD7KhL4iPrnanwA46XSDh6pMGGo7RvlWgdpCoQHE9taY Qwew== X-Gm-Message-State: AC+VfDxJo0uI+72Sc9JKOPo4awPWPeDqLgvxx2ue3fstEo4bxS6RNSu/ bDtlAYDqZwXobDulQUrUk1Lp1Q== X-Google-Smtp-Source: ACHHUZ6KsmwbD0WumVIxZybsAhOs0AkayBUKKYqlJF9vW/kh8LukQC/2MUJTJQo05NkI1GcIAc0zpw== X-Received: by 2002:a2e:8843:0:b0:2a7:6e85:e287 with SMTP id z3-20020a2e8843000000b002a76e85e287mr817003ljj.45.1685109750513; Fri, 26 May 2023 07:02:30 -0700 (PDT) Received: from builder (c188-149-203-37.bredband.tele2.se. [188.149.203.37]) by smtp.gmail.com with ESMTPSA id o20-20020a2e90d4000000b002aecfa8c58bsm741809ljg.40.2023.05.26.07.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 07:02:29 -0700 (PDT) Date: Fri, 26 May 2023 16:02:27 +0200 From: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez To: Parthiban.Veerasooran@microchip.com Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Horatiu.Vultur@microchip.com, Woojung.Huh@microchip.com, Nicolas.Ferre@microchip.com, Thorsten.Kummermehr@microchip.com Subject: Re: [PATCH net-next v3 2/6] net: phy: microchip_t1s: replace read-modify-write code with phy_modify_mmd Message-ID: References: <20230524144539.62618-1-Parthiban.Veerasooran@microchip.com> <20230524144539.62618-3-Parthiban.Veerasooran@microchip.com> <6eb6893f-7731-dcc5-9221-048383bcbce4@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6eb6893f-7731-dcc5-9221-048383bcbce4@microchip.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > >> /* Reference to AN1699 > >> * > >> https://ww1.microchip.com/downloads/aemDocuments/documents/AIS/ProductDocuments/SupportingCollateral/AN-LAN8670-1-2-config-60001699.pdf > >> * AN1699 says Read, Modify, Write, but the Write is not required if > >> the register already has the required value. So it is safe to use > >> phy_modify_mmd here. > >> */ > >> > >> So in future, if someone wants to know about this configuration they can > >> simply refer the AN1699. > >> > >> What do you think? > >> > > > > I'm not sure about the link, resources have a tendency to move. > Yes, I agree with you but somehow there is no way for giving the > reference to this document. May be we will keep this link for the > reference, later if someone is not able to access the link then they can > request Microchip to get the document. > > What do you think about this proposal? If you agree then I will proceed > for preparing the next version with your comments. Thumbs up from me R > > Otherwise LGTM > > > >> Best Regards, > >> Parthiban V >