From: Jiri Pirko <jiri@resnulli.us>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, Shyam-sundar.S-k@amd.com,
Sudheesh Mavila <sudheesh.mavila@amd.com>
Subject: Re: [PATCH net] amd-xgbe: fix the false linkup in xgbe_phy_status
Date: Fri, 26 May 2023 12:41:52 +0200 [thread overview]
Message-ID: <ZHCM8PinlpaA8RaO@nanopsycho> (raw)
In-Reply-To: <20230524174902.369921-1-Raju.Rangoju@amd.com>
Wed, May 24, 2023 at 07:49:02PM CEST, Raju.Rangoju@amd.com wrote:
>In the event of a change in XGBE mode, the current auto-negotiation
>needs to be reset and the AN cycle needs to be re-triggerred. However,
>the current code ignores the return value of xgbe_set_mode(), leading to
>false information as the link is declared without checking the status
>register.
>
>Fix this by propogating the mode switch status information to
>xgbe_phy_status().
>
>Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
>Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd.com>
>Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd.com>
>Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
prev parent reply other threads:[~2023-05-26 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 17:49 [PATCH net] amd-xgbe: fix the false linkup in xgbe_phy_status Raju Rangoju
2023-05-25 8:40 ` Simon Horman
2023-05-26 10:41 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHCM8PinlpaA8RaO@nanopsycho \
--to=jiri@resnulli.us \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudheesh.mavila@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).