From: Jiri Pirko <jiri@resnulli.us>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Kees Cook <keescook@chromium.org>, Jiri Benc <jbenc@redhat.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
Date: Fri, 26 May 2023 18:10:32 +0200 [thread overview]
Message-ID: <ZHDZ+G51wKK3/XMi@nanopsycho> (raw)
In-Reply-To: <366861a7-87c8-4bbf-9101-69dd41021d07@kili.mountain>
Fri, May 26, 2023 at 03:39:15PM CEST, dan.carpenter@linaro.org wrote:
>The "len" variable needs to be signed for the error handling to work
>correctly.
>
>Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
>Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-05-26 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 13:39 [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter() Dan Carpenter
2023-05-26 13:59 ` David Howells
2023-05-26 16:10 ` Jiri Pirko [this message]
2023-05-30 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHDZ+G51wKK3/XMi@nanopsycho \
--to=jiri@resnulli.us \
--cc=alexanderduyck@fb.com \
--cc=asml.silence@gmail.com \
--cc=brouer@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=jbenc@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox