From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51CD7E for ; Tue, 30 May 2023 20:37:02 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1110196 for ; Tue, 30 May 2023 13:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wdHfAXVFhPNft1q83C2Le5C8wgEEzlrlEwtjczVCbOE=; b=tAG1kPPF56amc+8ekxLAmKE5ey ffhAWQZA4OZ/MiLbt8Yij+Fuovn5QVRDT6XfXZ7jwVemvFcJH9j0VCfWHJnyqaMhG4nk6frfhdz/x +tv6ajwJ7/4zVJv1pyMS9M7oIDC1oTEb8SXqE3TUiM7a58KBNd9O3zlVNTE2ySJkbT8pGTr8jRXw+ u14Yn0TMVh2ty1aCXIgqYYHrVf8X4sPFcOrok6ASZwlth9M2svgez7FFv47n3HbVsW6fNtk9AITne WUAz/wDQIh+h7L90brVmQBvHsp4qknAtayVNQyDuOLtDWOOeuw97qTHNSMLnBiIvIsFyeTbKE+VHU 54W3jDiw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60596) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q464d-0003Rl-Dh; Tue, 30 May 2023 21:36:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q464c-0008Mz-CO; Tue, 30 May 2023 21:36:06 +0100 Date: Tue, 30 May 2023 21:36:06 +0100 From: "Russell King (Oracle)" To: Florian Fainelli Cc: Andrew Lunn , netdev , Heiner Kallweit , Oleksij Rempel Subject: Re: [RFC/RFTv3 00/24] net: ethernet: Rework EEE Message-ID: References: <20230331005518.2134652-1-andrew@lunn.ch> <5b49919e-ff70-b17d-0b15-ea87c86bc703@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b49919e-ff70-b17d-0b15-ea87c86bc703@gmail.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, May 30, 2023 at 01:03:15PM -0700, Florian Fainelli wrote: > On 5/30/23 12:48, Andrew Lunn wrote: > > I don't really care much what we decide means 'enabled'. I just want > > it moved out of MAC drivers and into the core so it is consistent. > > Understood this is slightly out of the scope of what you are doing which is > to have an unified behavior, but we also have a shot at defining a correct > behavior. Yes, having unified behaviour is good only if we don't end up boxing ourselves into a corner when trying to unify it. That said, I suspect many are just broken in one way or another. What always makes me rather nervous is that trying to fix this kind of thing will inevitably change the user visible behaviour, and then we hope that that doesn't cause people's setups to regress. So, IMHO, if we can decide what the correct behaviour and use should be before we unify it, the better chance we stand at not having differing behaviours from future kernel versions as we end up revising the unified behaviour. I hope that makes sense! :) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!