public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com
Subject: Re: [PATCH net-next] devlink: make health report on unregistered instance warn just once
Date: Wed, 31 May 2023 08:28:07 +0200	[thread overview]
Message-ID: <ZHbo95hVv5Fimlna@nanopsycho> (raw)
In-Reply-To: <20230531015523.48961-1-kuba@kernel.org>

Wed, May 31, 2023 at 03:55:23AM CEST, kuba@kernel.org wrote:
>Devlink health is involved in error recovery. Machines in bad
>state tend to be fairly unreliable, and occasionally get stuck
>in error loops. Even with a reasonable grace period devlink health
>may get a thousand reports in an hour.
>
>In case of reporting on an unregistered devlink instance
>the subsequent reports don't add much value. Switch to
>WARN_ON_ONCE() to avoid flooding dmesg and fleet monitoring
>dashboards.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Thanks!

  reply	other threads:[~2023-05-31  6:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  1:55 [PATCH net-next] devlink: make health report on unregistered instance warn just once Jakub Kicinski
2023-05-31  6:28 ` Jiri Pirko [this message]
2023-06-01  5:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHbo95hVv5Fimlna@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox