From: Simon Horman <simon.horman@corigine.com>
To: Michal Smulski <msmulski2@gmail.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com,
netdev@vger.kernel.org, Michal Smulski <michal.smulski@ooma.com>
Subject: Re: [PATCH net-next v3] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x
Date: Wed, 31 May 2023 18:38:36 +0200 [thread overview]
Message-ID: <ZHd4DJa7ha2Szne5@corigine.com> (raw)
In-Reply-To: <20230531055010.990-1-michal.smulski@ooma.com>
On Tue, May 30, 2023 at 10:50:10PM -0700, Michal Smulski wrote:
> Enable USXGMII mode for mv88e6393x chips. Tested on Marvell 88E6191X.
>
> Signed-off-by: Michal Smulski <michal.smulski@ooma.com>
> @@ -984,6 +985,64 @@ static int mv88e6393x_serdes_pcs_get_state_10g(struct mv88e6xxx_chip *chip,
> state->speed = SPEED_10000;
> state->duplex = DUPLEX_FULL;
> }
> + return 0;
> +}
> +
> +/* USXGMII registers for Marvell switch 88e639x are undocumented and this function is based
> + * on some educated guesses. There does not seem to bit status bit related to
> + * autonegotion complete or flow control.
Hi Michal,
: checkpatch --codespell suggests s/autonegotion/autonegotiation/
next prev parent reply other threads:[~2023-05-31 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 5:50 [PATCH net-next v3] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x Michal Smulski
2023-05-31 16:38 ` Simon Horman [this message]
2023-05-31 17:43 ` Michal Smulski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHd4DJa7ha2Szne5@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=michal.smulski@ooma.com \
--cc=msmulski2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).