From: Simon Horman <simon.horman@corigine.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: pch_gbe: Allow build on MIPS_GENERIC kernel
Date: Wed, 31 May 2023 23:50:26 +0200 [thread overview]
Message-ID: <ZHfBIkdXeP5rc7Lf@corigine.com> (raw)
In-Reply-To: <20230530150301.9555-1-jiaxun.yang@flygoat.com>
[ Fixed Jakub's email address ]
On Tue, May 30, 2023 at 04:03:01PM +0100, Jiaxun Yang wrote:
> MIPS Boston board, which is using MIPS_GENERIC kernel is using
> EG20T PCH and thus need this driver.
>
> Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
> board-boston.config for a while, some how it's never wired up
> in Kconfig.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> Netdev maintainers, is it possible to squeeze this tiny patch into
> fixes tree?
Hi Jianxun Yang,
with this patch applied on top of net [1] I see the following.
Am I doing something wrong?
ARCH=mips
$ make defconfig
CONFIG: mips-gcc-12.2.0
*** Default configuration is based on target '32r2el_defconfig'
Using ./arch/mips/configs/generic_defconfig as base
Merging arch/mips/configs/generic/32r2.config
Merging arch/mips/configs/generic/el.config
Merging ./arch/mips/configs/generic/board-boston.config
Merging ./arch/mips/configs/generic/board-marduk.config
Merging ./arch/mips/configs/generic/board-ni169445.config
Merging ./arch/mips/configs/generic/board-ocelot.config
Merging ./arch/mips/configs/generic/board-ranchu.config
Merging ./arch/mips/configs/generic/board-sead-3.config
Merging ./arch/mips/configs/generic/board-virt.config
Merging ./arch/mips/configs/generic/board-xilfpga.config
WARNING: unmet direct dependencies detected for PTP_1588_CLOCK_PCH
Depends on [n]: (X86_32 || COMPILE_TEST [=n]) && HAS_IOMEM [=y] && PCI [=y] && NET [=y] && PTP_1588_CLOCK [=y]
Selected by [y]:
- PCH_GBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_OKI [=y] && PCI [=y] && (MIPS_GENERIC [=y] || X86_32 || COMPILE_TEST [=n]) && PTP_1588_CLOCK [=y]
#
# configuration written to .config
#
Other than the warning a kernel build with this config seemed to work fine
[1] 7ba0732c805f ("Merge branch 'selftests-mptcp-skip-tests-not-supported-by-old-kernels-part-1'")
https://git.kernel.org/netdev/net/c/7ba0732c805f
Also, if the patch is targeted at 'net' then that should be noted in the
subject.
Subject: [PATCH net] ...
And 'pch_gbe: ' is probably a slightly better prefix.
Subject: [PATCH net] pch_gbe: ...
...
prev parent reply other threads:[~2023-05-31 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:03 [PATCH] net: pch_gbe: Allow build on MIPS_GENERIC kernel Jiaxun Yang
2023-05-31 21:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHfBIkdXeP5rc7Lf@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).