From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>,
saeedm@nvidia.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: simplify condition after napi budget handling change
Date: Wed, 31 May 2023 15:04:10 -0700 [thread overview]
Message-ID: <ZHfEWnhQfrEKOgOe@x130> (raw)
In-Reply-To: <20230530221943.63300b4c@kernel.org>
On 30 May 22:19, Jakub Kicinski wrote:
>reminder: please avoid top posting on the list
>
>On Tue, 30 May 2023 20:05:32 -0700 Rahul Rameshbabu wrote:
>> You might want to clean up
>> drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c as well in the
>> mlx5e_ptp_napi_poll function as well.
>>
>> static int mlx5e_ptp_napi_poll(struct napi_struct *napi, int budget)
>
>This is a separate NAPI instance, I don't think I should be touching
>this. I can remove a check from TLS, tho, it seems:
>
I will apply this to net-next-mlx5 as is, Rahul and Tariq can follow up on
PTP and TLS if necessary
prev parent reply other threads:[~2023-05-31 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:00 [PATCH net-next] net/mlx5e: simplify condition after napi budget handling change Jakub Kicinski
2023-05-31 3:05 ` Rahul Rameshbabu
2023-05-31 5:19 ` Jakub Kicinski
2023-05-31 22:04 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHfEWnhQfrEKOgOe@x130 \
--to=saeed@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).