netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org
Subject: QUSGMII control word
Date: Fri, 2 Jun 2023 13:18:03 +0100	[thread overview]
Message-ID: <ZHnd+6FUO77XFJvQ@shell.armlinux.org.uk> (raw)

Hi Maxime,

Looking at your commit which introduced QUSGMII -
5e61fe157a27 ("net: phy: Introduce QUSGMII PHY mode"), are you sure
your decoding of the control word is correct?

I've found some information online which suggests that QUSGMII uses a
slightly different format to the control word from SGMII. Most of the
bits are the same, but the speed bits occupy the three bits from 11:9,
and 10M, 100M and 1G are encoded using bits 10:9, whereas in SGMII
they are bits 11:10. In other words, in QUSGMII they are shifted one
bit down. In your commit, you used the SGMII decoder for QUSGMII,
which would mean we'd be picking out the wrong bits for decoding the
speed.

QUSGMII also introduces EEE information into bits 8 and 7 whereas
these are reserved in SGMII.

Please could you take a look, because I think we need a different
decoder for the QUSGMII speed bits.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

             reply	other threads:[~2023-06-02 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 12:18 Russell King (Oracle) [this message]
2023-06-05  6:13 ` QUSGMII control word Maxime Chevallier
2023-06-05 10:45   ` Russell King (Oracle)
2023-06-05 12:25   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHnd+6FUO77XFJvQ@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).