From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
s.hauer@pengutronix.de, arm@kernel.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: vf610: ZII: Add missing phy-mode and fixed links
Date: Sun, 4 Jun 2023 13:24:35 +0100 [thread overview]
Message-ID: <ZHyCg+Anqsdvt4V9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230604120748.GC4199@dragon>
On Sun, Jun 04, 2023 at 08:07:48PM +0800, Shawn Guo wrote:
> On Mon, May 29, 2023 at 04:35:07PM +0300, Vladimir Oltean wrote:
> > On Thu, May 25, 2023 at 08:26:06PM +0200, Andrew Lunn wrote:
> > > diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > > index 96495d965163..1a19aec8957b 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> > > @@ -202,7 +202,7 @@ port@5 {
> > >
> > > port@6 {
> > > reg = <6>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > > index 6280c5e86a12..6071eb6b33a0 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> > > @@ -75,7 +75,7 @@ fixed-link {
> > >
> > > port@6 {
> > > reg = <6>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > > index c00d39562a10..6f9878f124c4 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > > @@ -44,7 +44,7 @@ ports {
> > >
> > > port@0 {
> > > reg = <0>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > > index 7b3276cd470f..df1335492a19 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
> > > @@ -59,7 +59,7 @@ ports {
> > >
> > > port@0 {
> > > reg = <0>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> > > index 180acb0795b9..1461804ecaea 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> > > @@ -140,7 +140,7 @@ ports {
> > >
> > > port@0 {
> > > reg = <0>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > > index 73fdace4cb42..463c2452b9b7 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> > > @@ -129,7 +129,7 @@ ports {
> > >
> > > port@0 {
> > > reg = <0>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> > > diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > index 20beaa8433b6..f5ae0d5de315 100644
> > > --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > @@ -154,7 +154,7 @@ ports {
> > >
> > > port@0 {
> > > reg = <0>;
> > > - label = "cpu";
> > > + phy-mode = "rmii";
> > > ethernet = <&fec1>;
> > >
> > > fixed-link {
> >
> > Shouldn't these have been rev-rmii to be consistent with what was done
> > for arm64?
>
> Should I drop the patch for now, or can this be changed incrementally if
> needed?
What we have here is something that is "close enough". It isn't 100%
correct, but acceptable for the time being, and isn't something that
will ever become a problem, since the hardware itself can not have
its interface mode changed (it's set by pin strapping.)
It's something that can be fixed later.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-04 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 18:26 [PATCH v2] ARM: dts: vf610: ZII: Add missing phy-mode and fixed links Andrew Lunn
2023-05-27 13:24 ` Shawn Guo
2023-05-29 13:35 ` Vladimir Oltean
2023-06-04 12:07 ` Shawn Guo
2023-06-04 12:24 ` Russell King (Oracle) [this message]
2023-06-04 12:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHyCg+Anqsdvt4V9@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).