From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7BD723C6 for ; Sun, 4 Jun 2023 13:07:36 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1267BB8; Sun, 4 Jun 2023 06:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UzzrhBNawZ31nGxvXXuqa4J3SochyxihEmrfIV4DZvY=; b=PelkEpSR3NnJ2cgM83e2WDHOll K07RelK5yOLv8J8HBKdF4PjKS1SkWSDmh0aM/GN3rj9Po+21pkbm8ZHmV5kIt0quivrYckxH04EiK mI1MgVfcMFmLFzY3ggf8RfPa3mzXd3eXaBrRDmy7z5L+mhMCqN/ZSDgGPws7EdlP72LEE7kE0nKcz 5iYspNj739l3n5PHgOsxOYfDIn7+ZAPay1zcnPaHHnaeC1WMmPikJDR3htiVWtbafIsvxmjBSAEHZ qUdKdxUUkFtdLuVA/sxGTMvlfy12PskuB5qGj9LNbWg+eo8D3OXdWofb2nJSTEEIlOx0CCt/xFHci Zwsje9xw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48974) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q5nRx-0002cf-68; Sun, 04 Jun 2023 14:07:13 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q5nRr-00054c-EH; Sun, 04 Jun 2023 14:07:07 +0100 Date: Sun, 4 Jun 2023 14:07:07 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , erkin.bozoglu@xeront.com, mithat.guner@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured Message-ID: References: <20230522121532.86610-9-arinc.unal@arinc9.com> <20230522121532.86610-9-arinc.unal@arinc9.com> <20230524175107.hwzygo7p4l4rvawj@skbuf> <576f92b0-1900-f6ff-e92d-4b82e3436ea1@arinc9.com> <20230526130145.7wg75yoe6ut4na7g@skbuf> <7117531f-a9f2-63eb-f69d-23267e5745d0@arinc9.com> <826fd2fc-fbf8-dab7-9c90-b726d15e2983@arinc9.com> <20230604125517.fwqh2uxzvsa7n5hu@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230604125517.fwqh2uxzvsa7n5hu@skbuf> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Sun, Jun 04, 2023 at 03:55:17PM +0300, Vladimir Oltean wrote: > On Sun, Jun 04, 2023 at 01:18:04PM +0100, Russell King (Oracle) wrote: > > I don't remember whether Vladimir's firmware validator will fail for > > mt753x if CPU ports are not fully described, but that would be well > > worth checking. If it does, then we can be confident that phylink > > will always be used, and those bypassing calls should not be necessary. > > It does, I've just retested this: > > [ 8.469152] mscc_felix 0000:00:00.5: OF node /soc/pcie@1f0000000/ethernet-switch@0,5/ports/port@4 of CPU port 4 lacks the required "phy-handle", "fixed-link" or "managed" properties > [ 8.494571] mscc_felix 0000:00:00.5: error -EINVAL: Failed to register DSA switch > [ 8.502151] mscc_felix: probe of 0000:00:00.5 failed with error -22 ... which isn't listed in dsa_switches_apply_workarounds[], and neither is mt753x. Thanks. So, that should be sufficient to know that the CPU port will always properly described, and thus bypassing phylink in mt753x for the CPU port should not be necessary. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!