From: Simon Horman <simon.horman@corigine.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
alexandr.lobakin@intel.com, david.m.ertman@intel.com,
michal.swiatkowski@linux.intel.com,
marcin.szycik@linux.intel.com, pawel.chmielewski@intel.com,
sridhar.samudrala@intel.com, pmenzel@molgen.mpg.de,
dan.carpenter@linaro.org
Subject: Re: [PATCH iwl-next v4 02/13] ice: Prohibit rx mode change in switchdev mode
Date: Sun, 4 Jun 2023 15:59:53 +0200 [thread overview]
Message-ID: <ZHyY2TjJkFT46HZm@corigine.com> (raw)
In-Reply-To: <20230524122121.15012-3-wojciech.drewek@intel.com>
On Wed, May 24, 2023 at 02:21:10PM +0200, Wojciech Drewek wrote:
> Don't allow to change promisc mode in switchdev mode.
> When switchdev is configured, PF netdev is set to be a
> default VSI. This is needed for the slow-path to work correctly.
> All the unmatched packets will be directed to PF netdev.
>
> It is possible that this setting might be overwritten by
> ndo_set_rx_mode. Prevent this by checking if switchdev is
> enabled in ice_set_rx_mode.
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-04 14:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:21 [PATCH iwl-next v4 00/13] ice: switchdev bridge offload Wojciech Drewek
2023-05-24 12:21 ` [PATCH iwl-next v4 01/13] ice: Skip adv rules removal upon switchdev release Wojciech Drewek
2023-06-04 8:17 ` Simon Horman
2023-06-05 10:27 ` Drewek, Wojciech
2023-06-07 5:49 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 02/13] ice: Prohibit rx mode change in switchdev mode Wojciech Drewek
2023-06-04 13:59 ` Simon Horman [this message]
2023-06-12 7:30 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-06-13 9:41 ` Drewek, Wojciech
2023-06-13 10:14 ` Buvaneswaran, Sujai
2023-06-13 10:14 ` Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 03/13] ice: Don't tx before switchdev is fully configured Wojciech Drewek
2023-06-04 14:00 ` Simon Horman
2023-06-07 5:57 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 04/13] ice: Disable vlan pruning for uplink VSI Wojciech Drewek
2023-06-04 14:01 ` Simon Horman
2023-06-07 6:00 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 05/13] ice: Unset src prune on " Wojciech Drewek
2023-06-04 14:02 ` Simon Horman
2023-06-07 6:02 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 06/13] ice: Implement basic eswitch bridge setup Wojciech Drewek
2023-06-04 13:59 ` Simon Horman
2023-06-05 10:47 ` Drewek, Wojciech
2023-06-05 12:02 ` Simon Horman
2023-06-07 6:03 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 07/13] ice: Switchdev FDB events support Wojciech Drewek
2023-06-04 14:17 ` Simon Horman
2023-06-05 13:53 ` Drewek, Wojciech
2023-06-07 6:06 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 08/13] ice: Add guard rule when creating FDB in switchdev Wojciech Drewek
2023-06-04 16:08 ` Simon Horman
2023-06-07 6:22 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 09/13] ice: Accept LAG netdevs in bridge offloads Wojciech Drewek
2023-06-04 16:06 ` Simon Horman
2023-06-05 17:12 ` Drewek, Wojciech
2023-06-06 9:23 ` Simon Horman
2023-06-07 6:23 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 10/13] ice: Add VLAN FDB support in switchdev mode Wojciech Drewek
2023-06-04 16:37 ` Simon Horman
2023-06-05 17:45 ` Drewek, Wojciech
2023-06-07 6:25 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 11/13] ice: implement bridge port vlan Wojciech Drewek
2023-06-04 17:30 ` Simon Horman
2023-06-07 6:34 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 12/13] ice: implement static version of ageing Wojciech Drewek
2023-06-04 17:31 ` Simon Horman
2023-06-07 6:37 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2023-05-24 12:21 ` [PATCH iwl-next v4 13/13] ice: add tracepoints for the switchdev bridge Wojciech Drewek
2023-06-07 6:39 ` [Intel-wired-lan] " Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHyY2TjJkFT46HZm@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandr.lobakin@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.chmielewski@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).