From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
ansuelsmth@gmail.com, Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v0 3/3] net: phy: marvell: Add support for offloading LED blinking
Date: Sun, 18 Jun 2023 20:15:45 +0100 [thread overview]
Message-ID: <ZI9X4Qe2iHc2q6QH@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230618173937.4016322-3-andrew@lunn.ch>
On Sun, Jun 18, 2023 at 07:39:37PM +0200, Andrew Lunn wrote:
> Add the code needed to indicate if a given blinking pattern can be
> offloaded, to offload a pattern and to try to return the current
> pattern. It is expected that ledtrig-netdev will gain support for
> other patterns, such as different link speeds etc. So the code is
> over-engineers to make adding such additional patterns easy.
Hi Andrew,
What is the effect of this patch when LEDs are configured via the
existing DT property that allows arbitary register writes in this
driver?
There are a number of DTs that configure the LEDs this way, and
I don't think we would wish to regress that established configuration.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-18 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 17:39 [PATCH net-next v0 1/3] led: trig: netdev: Fix requesting offload device Andrew Lunn
2023-06-18 17:39 ` [PATCH net-next v0 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload Andrew Lunn
2023-06-19 14:18 ` Simon Horman
2023-06-19 18:11 ` Russell King (Oracle)
2023-06-19 20:34 ` Simon Horman
2023-06-19 21:27 ` Andrew Lunn
2023-06-18 17:39 ` [PATCH net-next v0 3/3] net: phy: marvell: Add support for offloading LED blinking Andrew Lunn
2023-06-18 19:15 ` Russell King (Oracle) [this message]
2023-06-18 20:28 ` Andrew Lunn
2023-06-18 17:50 ` [PATCH net-next v0 1/3] led: trig: netdev: Fix requesting offload device Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI9X4Qe2iHc2q6QH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).