netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <netdev@vger.kernel.org>, David George <David.George@sophos.com>,
	"Markus Trapp" <markus.trapp@secunet.com>
Subject: Re: [PATCH] xfrm: Use xfrm_state selector for BEET input
Date: Wed, 7 Jun 2023 10:57:38 +0200	[thread overview]
Message-ID: <ZIBGgjWwILqQziGe@gauss3.secunet.de> (raw)
In-Reply-To: <ZIBE62PYoLGzHgz7@gondor.apana.org.au>

On Wed, Jun 07, 2023 at 04:50:51PM +0800, Herbert Xu wrote:
> On Wed, Jun 07, 2023 at 10:47:45AM +0200, Steffen Klassert wrote:
> >
> > Hm, I thought about that one too. But x->sel.family can
> > also be AF_UNSPEC, in which case we used the address
> > family of the inner mode before your change.
> 
> It must not be AF_UNSPECT for BEET.  How would you even get the
> inner addresses if it were UNSPEC?
> 
> With BEET the inner addresses are stored in the IPsec SA rather
> than the actual packet.  So the family is also fixed for a given
> SA (which we call xfrm_state).

Right, Good point.

Thanks!

  reply	other threads:[~2023-06-07  8:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  9:26 [PATCH] xfrm: Remove inner/outer modes from input path Herbert Xu
2023-03-15 11:05 ` Steffen Klassert
2023-06-06 10:45 ` Steffen Klassert
2023-06-07  8:38   ` [PATCH] xfrm: Use xfrm_state selector for BEET input Herbert Xu
2023-06-07  8:47     ` Steffen Klassert
2023-06-07  8:50       ` Herbert Xu
2023-06-07  8:57         ` Steffen Klassert [this message]
2023-06-07  9:04           ` Herbert Xu
2023-06-12 11:46     ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIBGgjWwILqQziGe@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=David.George@sophos.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=markus.trapp@secunet.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).