From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
linux-rdma@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [net-next 13/15] net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure
Date: Wed, 7 Jun 2023 11:10:42 -0300 [thread overview]
Message-ID: <ZICP4kWm5moYRKm1@ziepe.ca> (raw)
In-Reply-To: <20230606220117.0696be3e@kernel.org>
On Tue, Jun 06, 2023 at 10:01:17PM -0700, Jakub Kicinski wrote:
> On Tue, 6 Jun 2023 00:12:17 -0700 Saeed Mahameed wrote:
> > Fixes: bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode")
> > Fixes: 8c98ee77d911 ("net/mlx5e: E-Switch, Add extack messages to devlink callbacks")
>
> The combination of net-next and Fixes is always odd.
> Why?
> Either it's important enough to be a fix or its not important
> and can go to net-next...
Generally I tell people to mark things as Fixes if it is a fix,
regardless of how small, minor or unimportant.
It helps backporters because they can suck in the original patch and
all the touchups then test that result. If people try to predict if it
is "important" or not they get it wrong quite often.
Fixes is not supposed to mean "this is important" or "send this to
-rc" or "apply it to -stable"
If it is really important add a 'cc: stable'.
If it is sort of important then send it to the -rc tree.
Otherwise dump it in the merge window.
But mark it with Fixes regardless
Jason
next prev parent reply other threads:[~2023-06-07 14:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:12 [pull request][net-next 00/15] mlx5 updates 2023-06-06 Saeed Mahameed
2023-06-06 7:12 ` [net-next 01/15] RDMA/mlx5: Free second uplink ib port Saeed Mahameed
2023-06-06 7:12 ` [net-next 02/15] {net/RDMA}/mlx5: introduce lag_for_each_peer Saeed Mahameed
2023-06-06 7:12 ` [net-next 03/15] net/mlx5: LAG, check if all eswitches are paired for shared FDB Saeed Mahameed
2023-06-06 7:12 ` [net-next 04/15] net/mlx5: LAG, generalize handling of " Saeed Mahameed
2023-06-06 7:12 ` [net-next 05/15] net/mlx5: LAG, change mlx5_shared_fdb_supported() to static Saeed Mahameed
2023-06-06 7:12 ` [net-next 06/15] net/mlx5: LAG, block multipath LAG in case ldev have more than 2 ports Saeed Mahameed
2023-06-06 7:12 ` [net-next 07/15] net/mlx5: LAG, block multiport eswitch " Saeed Mahameed
2023-06-06 7:12 ` [net-next 08/15] net/mlx5: Enable 4 ports VF LAG Saeed Mahameed
2023-06-06 7:12 ` [net-next 09/15] net/mlx5e: RX, Log error when page_pool size is too large Saeed Mahameed
2023-06-07 16:24 ` Alexander Lobakin
2023-06-07 16:40 ` Dragos Tatulea
2023-06-06 7:12 ` [net-next 10/15] net/mlx5e: Expose catastrophic steering error counters Saeed Mahameed
2023-06-06 7:12 ` [net-next 11/15] net/mlx5e: Remove RX page cache leftovers Saeed Mahameed
2023-06-06 7:12 ` [net-next 12/15] net/mlx5e: TC, refactor access to hash key Saeed Mahameed
2023-06-06 7:12 ` [net-next 13/15] net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure Saeed Mahameed
2023-06-07 5:01 ` Jakub Kicinski
2023-06-07 14:10 ` Jason Gunthorpe [this message]
2023-06-07 16:19 ` Jakub Kicinski
2023-06-07 23:18 ` Jason Gunthorpe
2023-06-07 15:46 ` Jiri Pirko
2023-06-07 16:22 ` Jakub Kicinski
2023-06-06 7:12 ` [net-next 14/15] mlx5/core: E-Switch, Allocate ECPF vport if it's an eswitch manager Saeed Mahameed
2023-06-06 7:12 ` [net-next 15/15] net/mlx5e: simplify condition after napi budget handling change Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZICP4kWm5moYRKm1@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).