From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E7634448 for ; Wed, 7 Jun 2023 14:13:16 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9FA410D7; Wed, 7 Jun 2023 07:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3T5RexQVbfA+VHoEyrP6w2iIV68bpAHWGq8VTMkiA/w=; b=cEtw03ybHWmNv3P0cpTTju7VmY gnJaPq8slq6VXz6q3KOP8ClMwRV+Jck8cT33qFMl5nhUJpeQ4GyLxcVBh34sgocejE7o0HmQt3PCG ohussvyYen6oTNC55KnNAGfA5T43bTD1TBKWgNVNta154LVRDh3Dc3czgeFMqgHp4HBbzLIuZR+oJ rSdCwkQ97yRmGw49ImZma0r2MXeSAFgnquVBxFNA6CYVGwSgsO8DsgacLIlJqN1APbpURaytdUR6S oL/gOgZZyJdhZPyUN5YRne3TTOlFSPeKq2VgeCAYtfSd9fAmiZ/qCL86L+wjeDhLDCgsF4Iy2xv2s LXljzaDw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46002) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6tuP-0007bf-Ff; Wed, 07 Jun 2023 15:13:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q6tuL-0008IN-3D; Wed, 07 Jun 2023 15:13:05 +0100 Date: Wed, 7 Jun 2023 15:13:05 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman , Maciej Fijalkowski , Feiyang Chen Subject: Re: [PATCH net-next v4 5/5] net: dwmac_socfpga: initialize local data for mdio regmap configuration Message-ID: References: <20230607135941.407054-1-maxime.chevallier@bootlin.com> <20230607135941.407054-6-maxime.chevallier@bootlin.com> <20230607165409.7fddd49a@pc-7.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607165409.7fddd49a@pc-7.home> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Jun 07, 2023 at 04:54:09PM +0200, Maxime Chevallier wrote: > On Wed, 7 Jun 2023 13:28:03 +0100 > "Russell King (Oracle)" wrote: > > > On Wed, Jun 07, 2023 at 03:59:41PM +0200, Maxime Chevallier wrote: > > > @@ -447,19 +446,22 @@ static int socfpga_dwmac_probe(struct platform_device *pdev) > > > struct mdio_regmap_config mrc; > > > struct regmap *pcs_regmap; > > > struct mii_bus *pcs_bus; > > > > > ... > > > + memset(&mrc, 0, sizeof(mrc)); > > ... > > > mrc.parent = &pdev->dev; > > > mrc.valid_addr = 0x0; > > > + mrc.autoscan = false; > > > > Isn't this covered by the memset() ? > > I have the same answer as for the above. It's redundant, but I don't > think there's any harm having it set explicitely ? No harm, just redundant. I don't think this is a good enough reason not to merge it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!