From: Simon Horman <horms@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] tools: ynl: Remove duplicate include
Date: Thu, 8 Jun 2023 13:46:13 +0200 [thread overview]
Message-ID: <ZIG/hX09UKccKFO7@kernel.org> (raw)
In-Reply-To: <20230608093036.96539-1-jiapeng.chong@linux.alibaba.com>
On Thu, Jun 08, 2023 at 05:30:36PM +0800, Jiapeng Chong wrote:
> ./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> tools/net/ynl/generated/netdev-user.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
> index aea5c7cc8ead..1883a658180b 100644
> --- a/tools/net/ynl/generated/netdev-user.c
> +++ b/tools/net/ynl/generated/netdev-user.c
> @@ -8,7 +8,6 @@
> #include "ynl.h"
> #include <linux/netdev.h>
>
> -#include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
> #include <libmnl/libmnl.h>
This duplicates:
- [PATCH -next] tools: ynl: Remove duplicated include in handshake-user.c
https://lore.kernel.org/all/20230608083148.5514-1-yang.lee@linux.alibaba.com/
So lets focus on that one.
In all three very similar patches were sent in a short space of time.
It's better not to do that.
--
pw-bot: reject
next prev parent reply other threads:[~2023-06-08 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 9:30 [PATCH] tools: ynl: Remove duplicate include Jiapeng Chong
2023-06-08 11:46 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-08 9:28 Jiapeng Chong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIG/hX09UKccKFO7@kernel.org \
--to=horms@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).