From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net 2/2] net: phylink: use USXGMII control-word format to parse Q-USGMII word
Date: Thu, 8 Jun 2023 17:32:52 +0100 [thread overview]
Message-ID: <ZIICtN5zrxvTuEwz@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230608163415.511762-4-maxime.chevallier@bootlin.com>
On Thu, Jun 08, 2023 at 06:34:15PM +0200, Maxime Chevallier wrote:
> diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h
> index 256b463e47a6..1d20a9082507 100644
> --- a/include/uapi/linux/mdio.h
> +++ b/include/uapi/linux/mdio.h
> @@ -444,4 +444,7 @@ static inline __u16 mdio_phy_id_c45(int prtad, int devad)
> #define MDIO_USXGMII_5000FULL 0x1a00 /* 5000Mbps full-duplex */
> #define MDIO_USXGMII_LINK 0x8000 /* PHY link with copper-side partner */
>
> +/* Usgmii control word is based on Usxgmii, masking away 2.5, 5 and 10Gbps */
> +#define MDIO_USGMII_SPD_MASK 0x0600
This isn't correct:
11:9 Speed: Bit 11, 10, 9:
1 1 1 to 011 = Reserved
0 1 0 = 1000 Mbps: 1000BASE-TX, 1000BASE-X
0 0 1 = 100 Mbps: 100BASE-TX, 100BASE-FX
0 0 0 = 10 Mbps: 10BASET, 10BASE2, 10BASE5
If we only look at bits 10 and 9, then we're interpreting the reserved
combinations as valid as well.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-08 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:34 [PATCH net 0/2] fixes for Q-USGMII speeds and autoneg Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 1/2] net: phylink: report correct max speed for QUSGMII Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word Maxime Chevallier
2023-06-08 16:33 ` Russell King (Oracle)
2023-06-08 17:54 ` Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 2/2] net: phylink: use USXGMII control-word format to parse Q-USGMII word Maxime Chevallier
2023-06-08 16:32 ` Russell King (Oracle) [this message]
2023-06-08 17:53 ` Maxime Chevallier
2023-06-08 17:30 ` Russell King (Oracle)
2023-06-09 8:09 ` Maxime Chevallier
2023-06-08 17:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIICtN5zrxvTuEwz@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Allan.Nielsen@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).