From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB742110E for ; Thu, 8 Jun 2023 16:33:01 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D54BA2; Thu, 8 Jun 2023 09:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1jYpLgX3TyKo27bhaTBgrRuXiTSjl0K9lkey+D4tgic=; b=pjTEEGJMNwzFRrqZOgtgTVTn/W z+5eGQ69RyPJ9ZeVT9PITVdfenLOoOc8c2qAgN0/fsk9/uVkRbJcm1/KrUvvGxHOCgOLsVwtSHy6I 2iK4xGuga/IA/ZRGLhShHVQlvZ3Jt19Fz/X8jUpHd3pB8VwfgphY2vTx+hOzXeOq13i4vM4ii4gYs MfmDtV6gn5Jptu7n5sRHlYk/TRJdZoL+hrW/SrKsEKqS/9oTr6T2IJVVNhqT1eYOkWQnADKmoJQDt TR/lUjQmiZBIqer580/a/Z2033P2jrxi3aVj8jEWVVfqH9t5RE7zVwrtWioFkOJM1zscr2yb50nc+ oTWji+Ww==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58578) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7IZC-0000g0-Km; Thu, 08 Jun 2023 17:32:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q7IZA-0000xW-5O; Thu, 08 Jun 2023 17:32:52 +0100 Date: Thu, 8 Jun 2023 17:32:52 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com, Vladimir Oltean Subject: Re: [PATCH net 2/2] net: phylink: use USXGMII control-word format to parse Q-USGMII word Message-ID: References: <20230608163415.511762-1-maxime.chevallier@bootlin.com> <20230608163415.511762-4-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608163415.511762-4-maxime.chevallier@bootlin.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Jun 08, 2023 at 06:34:15PM +0200, Maxime Chevallier wrote: > diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h > index 256b463e47a6..1d20a9082507 100644 > --- a/include/uapi/linux/mdio.h > +++ b/include/uapi/linux/mdio.h > @@ -444,4 +444,7 @@ static inline __u16 mdio_phy_id_c45(int prtad, int devad) > #define MDIO_USXGMII_5000FULL 0x1a00 /* 5000Mbps full-duplex */ > #define MDIO_USXGMII_LINK 0x8000 /* PHY link with copper-side partner */ > > +/* Usgmii control word is based on Usxgmii, masking away 2.5, 5 and 10Gbps */ > +#define MDIO_USGMII_SPD_MASK 0x0600 This isn't correct: 11:9 Speed: Bit 11, 10, 9: 1 1 1 to 011 = Reserved 0 1 0 = 1000 Mbps: 1000BASE-TX, 1000BASE-X 0 0 1 = 100 Mbps: 100BASE-TX, 100BASE-FX 0 0 0 = 10 Mbps: 10BASET, 10BASE2, 10BASE5 If we only look at bits 10 and 9, then we're interpreting the reserved combinations as valid as well. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!